Localize decimal fields #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n or admin.TabularInline all DecimalField's are localized.
…o make it inheritable by other forms.
|
+1, This is important, and I see no issues with this patch. Just to make a point: most my clients are Canadian, and French and English have different numerical localizations |
|
Ok, this looks sensible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately in the build-in Django admin views, there is no easy way to localize model fields of type DecimalField.
This mixin can help authors of admin views to localize fields of type DecimalField with minimum effort. It is specially useful for customers in countries, where decimal numbers are separated using a comma instead of a dot.
See also https://code.djangoproject.com/ticket/13546