Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 redesign Use treefmt #491

Merged
merged 11 commits into from
Nov 12, 2022
Merged

🧠 redesign Use treefmt #491

merged 11 commits into from
Nov 12, 2022

Conversation

Lord-Valen
Copy link
Contributor

Similar to #453 but using treefmt. Formatting should be applied with an additional commit or PR, probably the latter (it becomes hard to read the changes otherwise).

Copy link
Member

@Pacman99 Pacman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for getting this to happen! Does this PR include formattting digga library code?

@Lord-Valen
Copy link
Contributor Author

To reduce diff clutter, this PR doesn't include any changes made by formatters (they also make merge conflicts hell). We can run fmt later.

Copy link
Contributor

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake.nix Outdated
@@ -148,6 +147,7 @@
'';

# digga-local use
formatter = nixlib.lib.genAttrs supportedSystems (s: nixpkgs.legacyPackages.${s}.alejandra);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pacman99 What is the purpose of this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets alejanda for all supported systems onto nix fmt jobs

Copy link
Contributor

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Lord-Valen
Copy link
Contributor Author

A lock file was added, causing the test failures. Strange that .gitignore did not catch it.

@Lord-Valen
Copy link
Contributor Author

A lock file was added, causing the test failures. Strange that .gitignore did not catch it.

Annoyingly, .gitignore files in subdirectories override the .gitignore files in parent directories.

@blaggacao blaggacao merged commit 54ede8e into divnix:main Nov 12, 2022
@blaggacao
Copy link
Contributor

It's done! Further fixups will have to raise the PR count.⏩🤘

Thank you!

@blaggacao
Copy link
Contributor

Since you seem.to be interested in good developer tooling, there's also conform & lefthook as adopted in divnix/std...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants