-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧠 redesign
Use treefmt
#491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for getting this to happen! Does this PR include formattting digga library code?
To reduce diff clutter, this PR doesn't include any changes made by formatters (they also make merge conflicts hell). We can run fmt later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, for the actual formatting commit, do: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
flake.nix
Outdated
@@ -148,6 +147,7 @@ | |||
''; | |||
|
|||
# digga-local use | |||
formatter = nixlib.lib.genAttrs supportedSystems (s: nixpkgs.legacyPackages.${s}.alejandra); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pacman99 What is the purpose of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets alejanda for all supported systems onto nix fmt
jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
A lock file was added, causing the test failures. Strange that |
Annoyingly, .gitignore files in subdirectories override the .gitignore files in parent directories. |
It's done! Further fixups will have to raise the PR count.⏩🤘 Thank you! |
Since you seem.to be interested in good developer tooling, there's also |
Similar to #453 but using treefmt. Formatting should be applied with an additional commit or PR, probably the latter (it becomes hard to read the changes otherwise).