Format with alejandra #453
Conversation
Pacman99
force-pushed
the
formatting
branch
2 times, most recently
from
d6eff0f
to
a05017f
Compare
Pacman99
force-pushed
the
formatting
branch
2 times, most recently
from
204da4f
to
41ac43c
Compare
|
I haven't yet used https://github.com/numtide/treefmt, but it looks pretty useful as "One CLI to format the code tree". @blaggacao originally introduced its usage in the devshell changes reverted in #444. Looks like it could handle formatting for Considering formatting changes are usually pretty disruptive, it might be worth resurrecting the usage of |
| value = '' extra-experimental-features = nix-command flakes | ||
| extra-substituters = https://nrdxp.cachix.org https://nix-community.cachix.org | ||
| extra-trusted-public-keys = nrdxp.cachix.org-1:Fc5PSqY2Jm1TrWfm88l6cvGWwz3s93c6IOifQWnhNW4= nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=''; |
There was a problem hiding this comment.
| value = '' extra-experimental-features = nix-command flakes | |
| extra-substituters = https://nrdxp.cachix.org https://nix-community.cachix.org | |
| extra-trusted-public-keys = nrdxp.cachix.org-1:Fc5PSqY2Jm1TrWfm88l6cvGWwz3s93c6IOifQWnhNW4= nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=''; | |
| value = '' | |
| extra-experimental-features = nix-command flakes | |
| extra-substituters = https://nrdxp.cachix.org https://nix-community.cachix.org | |
| extra-trusted-public-keys = nrdxp.cachix.org-1:Fc5PSqY2Jm1TrWfm88l6cvGWwz3s93c6IOifQWnhNW4= nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs= | |
| ''; |
| # tempfix: remove when merged https://github.com/numtide/devshell/pull/123 | ||
| devshell.startup.load_profiles = pkgs.lib.mkForce (pkgs.lib.noDepEntry '' | ||
| # PATH is devshell's exorbitant privilige: | ||
| # fence against its pollution | ||
| _PATH=''${PATH} | ||
| # Load installed profiles | ||
| for file in "$DEVSHELL_DIR/etc/profile.d/"*.sh; do | ||
| # If that folder doesn't exist, bash loves to return the whole glob | ||
| [[ -f "$file" ]] && source "$file" | ||
| done | ||
| # Exert exorbitant privilige and leave no trace | ||
| export PATH=''${_PATH} | ||
| unset _PATH | ||
| ''); |
There was a problem hiding this comment.
I've been eyeing this for a bit: is it still necessary? Looks like numtide/devshell#123 is fixed.
There was a problem hiding this comment.
Yeah I'm not entirely sure about this either. I'll remove it and check if anything breaks.
There was a problem hiding this comment.
Yes, this is fixed. Thx!
|
Since treefmt was mentioned, we have a pretty useful solution at work that uses a devshell pre-commit hook to call treefmt on the entire repo before any commits are made. I don't think anybody would mind if we steal it: I know we had something very similar here before, not sure if we still do |
|
Definitely, I'll setup treefmt here. We still have the pre-commit hook for devos, but it was never added to digga's devshell, I can do that here to. And we can switch to treefmt in the hook too. Right now it uses nixpkgs-fmt. |
|
This can be closed since #491 was merged. |
alejandra seems like the best choice out there and our codebase would look a lot cleaner with this.
This should probably be merged after #438, so we don't have to deal with the conflicts.
The first commit is me, the second commit is all alejandra.
nix 2.8 isn't in nixpkgs yet, but you can always do
nix develop -c fmt