Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: fix pass overlays to devshell as well #89

Closed
wants to merge 3 commits into from

Conversation

@blaggacao
Copy link
Contributor Author

Apparently it yet doesn't do what I intended.

@blaggacao blaggacao marked this pull request as draft January 12, 2021 02:49
@blaggacao
Copy link
Contributor Author

I'm not sure if we generally want to do this since in casu it only affects nixflk's own shell.nix. The reason I wanted to attempt it is to pass along nixUnstable, so that we have better control over latest and greatest nix features. (I'm not sure how much stable branch lags behind, yesterday it was just a few days f a release).

While dogfooding the overlays is probably right, I'm not entirely sure about the overrides.

On the other hand, thinking twice, maybe passing overlays to specifically nixflk/shell.nix maybe is overkill and should be avoided.

So I'll retract here and adapt my flake-utils PR accordingly with a hint for reasoning.

@blaggacao blaggacao closed this Jan 12, 2021
@blaggacao
Copy link
Contributor Author

I correct: we need it upstream in flake-utils for a potentially more generic use case, but we don't need it here for the current nixflk/shell.nix. If flake-utils should be adapted, we could get it for free, then.

@blaggacao blaggacao deleted the da-dogfood-on-devshell branch January 25, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant