Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ESLint v9 #814

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Upgrade to ESLint v9 #814

merged 2 commits into from
Aug 1, 2024

Conversation

divergentdave
Copy link
Contributor

@divergentdave divergentdave commented May 13, 2024

This upgrades to ESLint v9 and an alpha version of typescript-eslint. This PR also switches from the now-deprecated eslintrc configuration file to a "flat config", changes the command line used with eslint to match, and cleans up some unused eslint-disable directives.

@divergentdave divergentdave marked this pull request as ready for review May 16, 2024 14:38
@divergentdave divergentdave requested a review from a team as a code owner May 16, 2024 14:38
@coveralls
Copy link

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 10186047410

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.847%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/vdaf/src/index.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10148947634: 0.01%
Covered Lines: 3470
Relevant Lines: 4101

💛 - Coveralls

package.json Outdated
@@ -41,6 +42,6 @@
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.2.0",
"typescript": "^5.3.3",
"typescript-eslint-language-service": "^5.0.5"
"typescript-eslint": "^8.0.0-alpha.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind taking taking this (it's just a dev dependency), but is there any urgency driving us to upgrade to an alpha version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Dependabot churn, which could alternately be addressed with an ignore

@divergentdave
Copy link
Contributor Author

This is now ready to go, as typescript-eslint v8.0.0 has been released. https://typescript-eslint.io/blog/announcing-typescript-eslint-v8

@divergentdave divergentdave merged commit d840124 into main Aug 1, 2024
4 checks passed
@divergentdave divergentdave deleted the david/eslint-upgrade branch August 1, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants