Task rewrite: integration tests #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
approved these changes
Sep 29, 2023
| .collect::<Vec<_>>() | ||
| .try_into() | ||
| .unwrap(); | ||
| task_parameters.endpoint_fragments.leader_endpoint_path = "/v04/".to_string(); |
There was a problem hiding this comment.
I think this needs to change as well, so the collector doesn't get a 404 when talking to the Janus leader.
tgeoghegan
force-pushed
the
timg/new-task-janus-cli
branch
from
ad70bb9
to
64ddc4f
Compare
Adopts `AggregatorTask`, `test_util::Task` and `NewTaskBuilder` across the integration test and interop binaries modules. Part of #1524
tgeoghegan
force-pushed
the
timg/new-task-integration-tests
branch
from
867e80c
to
a63034e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #2028
Adopts
AggregatorTask,test_util::TaskandNewTaskBuilderacross the integration test and interop binaries modules.Part of #1524