-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag to hide PRG. #272
Conversation
4d0ebd6
to
6a36698
Compare
I've created a little copy & paste PoC to see if this actually works: https://github.com/simon-friedberger/priouser It did require a lot of copy pasting of things for testing. Does anybody have an idea how that could be improved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from deciding what to call the new feature, this is looking good. Just a few minor comments.
Are you referring to |
Yes, I think exposing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm ready to approve. First, I think it would be useful to add some context to the commit message. Plus, we should edit the top comment of this PR to point to the issue.
This allows removing the dependencies on several cryptographic libraries like aes, ctr and cipher. This option is helpful for users who want to use a different cryptographic library and implement their own version of the PRG based on that.
Looks great, thank you for this change @simon-friedberger! |
The motivation for this PR is to remove the dependencies on the crates aes, ctr and cmac so a user of the crate can rely on an existing crypto library. This should be dable by implementing analogues of
PrgAes128
andSeedStreamAes128
and constructing, e.g.Prio3Aes128Count = Prio3<Count<Field64>, PrgAes128Alt, 16>;
This would fix the remainder of #241.