Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XofHmacSha256Aes128 #901

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add XofHmacSha256Aes128 #901

merged 1 commit into from
Jan 11, 2024

Conversation

cjpatton
Copy link
Collaborator

An XOF based on HMAC-SHA256 and AES128. This XOF does not appear in the VDAF spec.

@cjpatton cjpatton requested a review from a team as a code owner January 11, 2024 15:43
Copy link
Contributor

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo conditional compilation fixes. It's kinda neat that this reuses SeedStreamAes128, with better key derivation.

src/vdaf/xof.rs Show resolved Hide resolved
@divergentdave
Copy link
Contributor

I briefly looked into whether XofHmacSha256Aes128 could be dropped into the experimental Prio2 VDAF we define, but unfortunately there's one difference: the XOF hashes a DST length byte and a DST first, before hashing the binder input, while the Prio2 VDAF only hashes the nonce. This means there's some minor duplication on the order of 3 lines of code, but oh well.

Cargo.toml Outdated Show resolved Hide resolved
An XOF based on HMAC-SHA256 and AES128. This XOF does not appear in the
VDAF spec.
@cjpatton cjpatton merged commit c5700ec into main Jan 11, 2024
6 checks passed
@cjpatton cjpatton deleted the cjpatton/xof-hmac-aes branch January 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants