Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to libc 0.2.135 and nix 0.25 #89

Merged
merged 3 commits into from
Oct 22, 2022
Merged

bump to libc 0.2.135 and nix 0.25 #89

merged 3 commits into from
Oct 22, 2022

Conversation

mbodmer
Copy link
Contributor

@mbodmer mbodmer commented Oct 20, 2022

No description provided.

@diwic
Copy link
Owner

diwic commented Oct 21, 2022

Hi and thanks for the PR, could you motivate why it is needed?

@mbodmer
Copy link
Contributor Author

mbodmer commented Oct 21, 2022

Well, it's not exactly needed, just keep going forward. I am trying to avoid double libc and nix dependencies, as CPAL also has bumped them. With libc it might be better to not specify the patch release and just keep it at "0.2" so it would leave the exact version to cargo's version resolution.

@mbodmer
Copy link
Contributor Author

mbodmer commented Oct 21, 2022

I've just found that it's also documented that way in libc: https://crates.io/crates/libc

@mbodmer
Copy link
Contributor Author

mbodmer commented Oct 21, 2022

I now also did the same for nix, this allows cargo to resolve for more version combinations. alsa-rs can handle them all, at least at this point in time

@mbodmer
Copy link
Contributor Author

mbodmer commented Oct 21, 2022

Hope this helps, thanks for reviewing :-)

@est31
Copy link

est31 commented Oct 21, 2022

From cpal's point of view, it would be nice to have this merged and after that, a release would be really good. Thanks!

@diwic
Copy link
Owner

diwic commented Oct 22, 2022

@est31 @mbodmer Released v0.6.1 now, enjoy!

@mbodmer
Copy link
Contributor Author

mbodmer commented Oct 22, 2022

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants