Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce releases? #57

Closed
jmdh opened this issue Jun 11, 2015 · 17 comments
Closed

Produce releases? #57

jmdh opened this issue Jun 11, 2015 · 17 comments

Comments

@jmdh
Copy link

jmdh commented Jun 11, 2015

Hello,

I'm looking at packaging this module for Debian, and noticed that you are producing regular releases but suggest that people download directly from master.

I wondered if you would consider making releases too, since this would make it easier to keep track of versions installed. We can work around this by renaming master.tar.gz to include 0.0.3+20150522, but this is a bit ugly and needs manual intervention.

Thanks for your work on this project!

P.S. the bug report about adding this to Debian is https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760962

@diyan
Copy link
Owner

diyan commented Jun 11, 2015

@jmdh This is a defect in a README file. User should use pip install pywinrm==version instead of master. I will fix readme and will add release tags into the Git repository.

@jmdh
Copy link
Author

jmdh commented Jun 11, 2015

Great, thanks!

On Thu, Jun 11, 2015 at 04:51:04AM -0700, Alexey Diyan wrote:

@jmdh This is a defect in a README file. User should use pip install pywinrm==version instead of master. I will fix readme and will add release tags into the Git repository.


Reply to this email directly or view it on GitHub:
#57 (comment)

@opoplawski
Copy link

Also, it would be good if the pip packages contained LICENSE and README.md for packaging.

@leegarrett
Copy link

Hi Alexey, could you release a source tarball for the latest version? Debian is currently stuck at 0.1.1 (which is the latest source tarball released), and packaging directly from git repos is frowned upon. It would help to get the latest release of pywinrm into Debian before the release freeze.

@jmdh
Copy link
Author

jmdh commented Dec 20, 2016

@leegarrett actually 0.0.3, but thanks for spotting this. I have dropped the ball on keeping this package updated in Debian and agree it would be good to get this fixed for the freeze.

@diyan
Copy link
Owner

diyan commented Dec 20, 2016

@leegarrett @jmdh OK, I will work on this. What do you need from my side other than tagging release on Github and updating CHANGELOG.md?

@nitzmahone
Copy link
Collaborator

The release process isn't fully automated- I did the last couple with a bdist_wheel and didn't include an sdist. I think I might be able to add the sdist without doing a new release, but lemme try it on test-pypi first...

@leegarrett
Copy link

@diyan To make me fully happy, https://pypi.python.org/simple/pywinrm/ should have a pywinrm-0.2.1.tar.gz as an end result.

@jmdh I'm currently preparing a new release, and noticed that the usual steps would have me end up with 0.1.1.

@nitzmahone
Copy link
Collaborator

@leegarrett I've added the corresponding sdist (.tar.gz) to the existing 0.2.1 release on pypi- does that get you where you need to be?

@diyan
Copy link
Owner

diyan commented Dec 20, 2016

@nitzmahone I'm preparing 0.2.2 release. Do you have anything to add into CHANGELOG?

https://github.com/diyan/pywinrm/blob/master/CHANGELOG.md#version-022

@nitzmahone
Copy link
Collaborator

@diyan Nope- the CredSSP stuff is the only thing that's been merged since 0.2.1, and Jordan already included it in the changelog in his PR. I was planning to do a pass over some Py3 bugs/tests to get everything happy before 0.2.2, but if you want to do it now, I can do that in 0.2.3 later...

@nitzmahone
Copy link
Collaborator

@diyan Oh nevermind, you added it to the changelog just now. For the pypi deploy, are you set up to do both bdist_wheel and sdist? You only used to do sdists, so just want to make sure both are available.

@diyan
Copy link
Owner

diyan commented Dec 20, 2016

@nitzmahone Let's tag 0.2.2 release now, ok?

In such way, @jmdh and @leegarrett could work on python2-winrm / python3-winrm packages for Debian. They have pretty outdated configuration and it will took some time to sync with latest pywinrm release.

Once you are ready you can tag bugfix release as v0.2.3 and guys will just increment version number.

@diyan
Copy link
Owner

diyan commented Dec 20, 2016

For the pypi deploy, are you set up to do both bdist_wheel and sdist?

Shame on me but I have no idea how to setup this. Could you do this for me - tag releases on GitHub and PyPI? Everything is ready from what I see. Changelog is up-to-date all tests are green on Travis / AppVeyor

@nitzmahone
Copy link
Collaborator

@diyan: No problem- that's why I asked. ;) I was able to add the tarball the Debian folks need to the existing 0.2.1 release on pypi. But I also think we're OK to release 0.2.2 now with just CredSSP support added. I know some folks are eagerly awaiting. :)

@diyan
Copy link
Owner

diyan commented Dec 20, 2016

@nitzmahone Awesome. Please do it once you feel ready.

@nitzmahone
Copy link
Collaborator

OK, 0.2.2 release is up on PyPI with CredSSP support- both sdist and bdist_wheel.

cc/ @jmdh @leegarrett - let me know if you need anything else on this end for packaging stuff. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants