Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several tests based off missing code coverage #198

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Added several tests based off missing code coverage #198

merged 2 commits into from
Jul 1, 2019

Conversation

mcassaniti
Copy link

This PR relates to #197.

I've added the following tests for Transport.build_session:

  • Testing that a trusted CA path sets session.verify regardless of server_cert_validation
  • Tested server_cert_validation=ignore code path
  • Tested invalid server_cert_validation value
  • Tested Kerberos delegation value as both valid and invalid string
  • Tested not providing a username or password when they should be required
  • Tested setting an invalid authentication mechanism
  • Tested setting an invalid encryption setting

I've also added a Session.run_ps test which should test various code paths. The test returns an error, so the std_err and return code are also tested.

@coveralls
Copy link

coveralls commented Dec 21, 2017

Coverage Status

Coverage increased (+6.6%) to 74.91% when pulling b04c90d on mcassaniti:new_tests into eb6a408 on diyan:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+6.6%) to 74.91% when pulling b04c90d on mcassaniti:new_tests into eb6a408 on diyan:master.

@coveralls
Copy link

coveralls commented Jan 2, 2018

Coverage Status

Coverage increased (+7.7%) to 75.986% when pulling d76ad98 on mcassaniti:new_tests into eb6a408 on diyan:master.

@mcassaniti
Copy link
Author

Thanks for taking a look. Much appreciated.

@badcure
Copy link
Collaborator

badcure commented Jun 11, 2019

@mcassaniti Do you mind rebasing your project?

@badcure badcure added the needs a rebase/merge Awaiting a merge/rebase from master label Jun 11, 2019
@badcure
Copy link
Collaborator

badcure commented Jul 1, 2019

Whoops, looks like I changed test_transport is structured after you re-based. Sorry about that.

I will create another PR based on your branch and fix the conflicts, since I have already spent some time with the new file.

@badcure badcure merged commit 027bc72 into diyan:master Jul 1, 2019
badcure added a commit that referenced this pull request Jul 1, 2019
Fixing merge conflict for PR #198: Added several tests based off missing code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs a rebase/merge Awaiting a merge/rebase from master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants