Merge Yeelight Music Mode (#329) #331

alexyao2015 · 2020-01-18T04:59:41Z

Implementation of Yeelight Music Mode
Yeelight now supports Philips Entertainment API
Changed entertainment service method to pass Host IP argument;
Changed sendLightRequest method to pass entertainment Host IP to turn on music mode on yeelight devices before sending them any commands;

Implemented YeelightConnection class which is now used to communicate with Yeelight devices and to maintain Yeelight Music Mode connections;
Implemented dictionary logic to support dedicated yeelight connections;

Fixed small string format error

This will serve as the pull request for #329
Fixes #327

Yeelight now supports Philips Entertainment API * Changed entertainment service method to pass Host IP argument; * Changed sendLightRequest method to pass entertainment Host IP to turn on music mode on yeelight devices before sending them any commands; + Implemented YeelightConnection class which is now used to communicate with Yeelight devices and to maintain Yeelight Music Mode connections; + Implemented dictionary logic to support dedicated yeelight connections;

* Implementation of Yeelight Music Mode Yeelight now supports Philips Entertainment API * Changed entertainment service method to pass Host IP argument; * Changed sendLightRequest method to pass entertainment Host IP to turn on music mode on yeelight devices before sending them any commands; + Implemented YeelightConnection class which is now used to communicate with Yeelight devices and to maintain Yeelight Music Mode connections; + Implemented dictionary logic to support dedicated yeelight connections; * Fixed small string format error

alexyao2015 · 2020-01-18T05:15:22Z

I happen to have 3 Yeelight bulbs and can confirm that the lights do change color, however, there is very noticeable latency with color changes. If memory serves correctly, I believe yeelight music mode is a reverse connection to the server to obtain the light data, which makes the latency confusing.

alexyao2015 · 2020-01-18T05:18:49Z

Also, it appears to be stuck in light sync mode... Not sure if thats related to this commit or not...

SilveIT · 2020-01-18T08:25:41Z

Yeah, I have noticed that latency too. Dunno where the problem might actually be, it might even be on Yeelight's side.

Mine sync mode works fine actually. There are some problems with syncWithLights (the bulb is online and connected in music mode, but has unreachable state), but hue sync sends commands properly even when the bulb is offline :D. Once I got my Yeelight to always "timed out" state, fixed it by switching off/on.

Also, you forgot to take one more commit b4061f5
Pulled it with one more in #332

* Implementation of Yeelight Music Mode Yeelight now supports Philips Entertainment API * Changed entertainment service method to pass Host IP argument; * Changed sendLightRequest method to pass entertainment Host IP to turn on music mode on yeelight devices before sending them any commands; + Implemented YeelightConnection class which is now used to communicate with Yeelight devices and to maintain Yeelight Music Mode connections; + Implemented dictionary logic to support dedicated yeelight connections; * Fixed small string format error * Small music mode listener improvement

alexyao2015 · 2020-01-18T16:19:18Z

I haven't gotten a chance to look very closely at the code, but I have don't more testing and have noticed the bulbs being stuck in light sync mode does appear to be related to this commit.

SilveIT · 2020-01-18T21:37:28Z

Some funny stuff. The first one isn't my fault, but the other is probably because of my code. Maybe I'll try to fix it later.

SilveIT · 2020-01-18T22:03:36Z

syncWithLights's and sendLightRequest's Connections dictionaries are same. Will fix it tomorrow...

SilveIT · 2020-01-20T11:58:17Z

This is insane... Merge #334 by the way..

* Implementation of Yeelight Music Mode Yeelight now supports Philips Entertainment API * Changed entertainment service method to pass Host IP argument; * Changed sendLightRequest method to pass entertainment Host IP to turn on music mode on yeelight devices before sending them any commands; + Implemented YeelightConnection class which is now used to communicate with Yeelight devices and to maintain Yeelight Music Mode connections; + Implemented dictionary logic to support dedicated yeelight connections; * Fixed small string format error * Small music mode listener improvement * syncWithLights timedelta fix and Yeelight's get_state rollback * Handle an exception in getIpAddress method

+ Added RGB argument to sendLightRequest and most of set_light methods to avoid double RGB conversion; * Fixed possibly incorrect brightness value in MiBox, ESPHome protocols; * Transition time in entertainment module is little bit dynamic now;

…-master # Conflicts: # BridgeEmulator/functions/entertainment.py

Resolving conflict

Fixed weird stuff with tabulation

Color brightness fixes + merged commits from master

mariusmotea · 2020-01-23T11:47:47Z

Is this tested, can be merged?

SilveIT · 2020-01-23T15:24:10Z

Not really, I can only test Yeelight protocol. Someone has to check the new logic of color brightness for Domoticz (2872804#diff-386e842c566c501e0c945a31f177beccR78-R81), ESPHome (2872804#diff-7227138d2fb9abccfe0f7c8e327e5989R199-R202), MiBox (2872804#diff-c6176cfbe026837caa0d86ebaead9f76R21-R24)

alexyao2015 · 2020-01-23T15:43:03Z

I'll test it this weekend.

alexyao2015 · 2020-01-25T20:49:51Z

I did some testing. This version seems to be improved from before, but there is still significant amounts of latency observed. Personally, I have not reviewed the code at all, so I am not sure if this is possible to get this to the speed that ESPHome bulbs can react. But in the current state, it is still pretty far away latency-wise.

SilveIT · 2020-01-25T20:54:28Z

Have you tested new color logic of Domoticz, ESPHome, MiBox? It should be ok, but I can't test. Also I don't quite understand what's the reason of this latency. Native Yeelight works perfect and zero-latency.

alexyao2015 · 2020-01-25T20:56:08Z

I haven't, I only tested Yeelight but I did notice when entertainment mode was supposed to flash white, it flashed a more off-white, pinkish color in testing. I have 3 Yeelight bulbs and there is latency, so I'm not quite sure what you mean by zero-latency.

SilveIT · 2020-01-25T20:58:32Z

Yes, I noticed that too, Yeelight's ~255;255;255 can be pinkish or greenish, I guess it might depend on previous commands.
Also I already mentioned it before #329 (comment)

SilveIT · 2020-01-25T22:34:01Z

I guess, I was wrong about no-delay in Yeelight app. It seems delayed too. It also doesn't seem like Yeelight has more or less white color in set_rgb. So, I don't think I can do anything about those problems at the moment.
I think it can be merged safely if the new colors on Domoticz, ESPHome, MiBox are all right.

alexyao2015 · 2020-01-25T22:42:42Z

Alright I'll take a look at the code and make sure the colors work properly. Once I do that, I'll merge it.

SilveIT · 2020-01-25T23:48:36Z

LOL, I have a really stupid idea. We can check if r=g=b with really small tolerance and use CT instead of RGB to get a better white color, because they are using different leds for white. Will check it later.

alexyao2015 · 2020-01-26T00:05:04Z

Small problem with that is the white LEDs might have a very different brightness range so you'll have to scale that accordingly.

SilveIT · 2020-01-26T20:59:42Z

It actually works! Yeah, I knew it would have a different brightness. In my case white leds are ~3 times brighter, so I just devided brightness by 3. I hope it's same with other Yeelights... The only small problem is that brightness command (set_bright) on CT to RGB transition causes weird blinking. May be it's not that nasty, may be I'm wrong, I'll commit it anyway.

UPD: That blinking between CT and RGB seems much more annoying than incorrect white, so I reverted that commit.

* Small changes to disconnect logic * Controversial changes relative to white * Using CT instead of RGB where color is nearly white; * Revert "Controversial changes relative to white" This reverts commit 1768f7f.

stale · 2020-02-16T01:03:19Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 2 days if no further activity occurs. Thank you for your contributions.

mariusmotea · 2020-03-30T19:42:16Z

Will be an update to this commit? The stale boot want to close it.

SilveIT · 2020-03-30T19:47:19Z

I don't know what to update. It works fine for me. I haven't tested other protocols than Yeelight.

mariusmotea · 2020-03-30T19:54:24Z

I see the file esphome.py is entirely replaced but with identical content so i believe you change only the end of the line from unix to windows format. Can you undo this so i can merge your work?

Thanks.

SilveIT · 2020-03-30T20:34:17Z

I tried dos2unix on this file, but it hasn't changed. I also don't see a commit where I could have ruined it. I made changes to it before, but it didn't replace all the lines. I tried dos2unix on a version of the file from the master branch of your repository and it replaces all lines there. I think my commit is fixing it.

SilveIT · 2020-03-30T20:37:48Z

Before that, a couple of changes were made to this file here: 2872804#diff-7227138d2fb9abccfe0f7c8e327e5989L12-L200

SilveIT and others added 3 commits January 17, 2020 00:35

Fixed small string format error

b4061f5

alexyao2015 mentioned this pull request Jan 18, 2020

Implementation of Yeelight Music Mode #329

Closed

Small music mode listener improvement

636bc26

SilveIT added 2 commits January 18, 2020 11:37

Merge branch 'master-yeelightmusic' into master

b1203d4

SilveIT added 2 commits January 19, 2020 17:26

syncWithLights timedelta fix and Yeelight's get_state rollback

986cc8e

Handle an exception in getIpAddress method

1d83de2

SilveIT and others added 9 commits January 20, 2020 14:04

Color brightness fixes

2872804

+ Added RGB argument to sendLightRequest and most of set_light methods to avoid double RGB conversion; * Fixed possibly incorrect brightness value in MiBox, ESPHome protocols; * Transition time in entertainment module is little bit dynamic now;

Merge branch 'master' of https://github.com/diyhue/diyHue into diyhue…

149d0e6

…-master # Conflicts: # BridgeEmulator/functions/entertainment.py

Merge branch 'diyhue-master'

ea93c97

Resolving conflict

Fixed weird stuff with tabulation

19919a5

Merge pull request #2 from SilveIT/diyhue-master

e6e0c09

Fixed weird stuff with tabulation

Git's core.autocrlf to false to fix end of the line

54a9349

Git's core.autocrlf to false to fix end of the line

e2afe1e

Merge pull request #339 from SilveIT/master

a74d5a8

Color brightness fixes + merged commits from master

White color logic + small disconnect optimization (#341)

6993f55

* Small changes to disconnect logic * Controversial changes relative to white * Using CT instead of RGB where color is nearly white; * Revert "Controversial changes relative to white" This reverts commit 1768f7f.

stale bot added the stale This issue is stale, and will be closed label Feb 16, 2020

alexyao2015 added the enhancement label Feb 16, 2020

stale bot removed the stale This issue is stale, and will be closed label Feb 16, 2020

Merge branch 'master' into master-yeelightmusic

e6c00a3

mariusmotea merged commit d52e8b2 into master Mar 31, 2020

alexyao2015 deleted the master-yeelightmusic branch May 23, 2020 07:38

SilveIT mentioned this pull request Feb 14, 2022

Yeelight Music Mode #327

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge Yeelight Music Mode (#329) #331

Merge Yeelight Music Mode (#329) #331

alexyao2015 commented Jan 18, 2020

alexyao2015 commented Jan 18, 2020

alexyao2015 commented Jan 18, 2020

SilveIT commented Jan 18, 2020

alexyao2015 commented Jan 18, 2020

SilveIT commented Jan 18, 2020

SilveIT commented Jan 18, 2020

SilveIT commented Jan 20, 2020

mariusmotea commented Jan 23, 2020

SilveIT commented Jan 23, 2020

alexyao2015 commented Jan 23, 2020

alexyao2015 commented Jan 25, 2020

SilveIT commented Jan 25, 2020

alexyao2015 commented Jan 25, 2020

SilveIT commented Jan 25, 2020 •

edited

Loading

SilveIT commented Jan 25, 2020

alexyao2015 commented Jan 25, 2020

SilveIT commented Jan 25, 2020

alexyao2015 commented Jan 26, 2020 •

edited

Loading

SilveIT commented Jan 26, 2020 •

edited

Loading

stale bot commented Feb 16, 2020

mariusmotea commented Mar 30, 2020

SilveIT commented Mar 30, 2020

mariusmotea commented Mar 30, 2020

SilveIT commented Mar 30, 2020

SilveIT commented Mar 30, 2020

Merge Yeelight Music Mode (#329) #331

Merge Yeelight Music Mode (#329) #331

Conversation

alexyao2015 commented Jan 18, 2020

alexyao2015 commented Jan 18, 2020

alexyao2015 commented Jan 18, 2020

SilveIT commented Jan 18, 2020

alexyao2015 commented Jan 18, 2020

SilveIT commented Jan 18, 2020

SilveIT commented Jan 18, 2020

SilveIT commented Jan 20, 2020

mariusmotea commented Jan 23, 2020

SilveIT commented Jan 23, 2020

alexyao2015 commented Jan 23, 2020

alexyao2015 commented Jan 25, 2020

SilveIT commented Jan 25, 2020

alexyao2015 commented Jan 25, 2020

SilveIT commented Jan 25, 2020 • edited Loading

SilveIT commented Jan 25, 2020

alexyao2015 commented Jan 25, 2020

SilveIT commented Jan 25, 2020

alexyao2015 commented Jan 26, 2020 • edited Loading

SilveIT commented Jan 26, 2020 • edited Loading

stale bot commented Feb 16, 2020

mariusmotea commented Mar 30, 2020

SilveIT commented Mar 30, 2020

mariusmotea commented Mar 30, 2020

SilveIT commented Mar 30, 2020

SilveIT commented Mar 30, 2020

SilveIT commented Jan 25, 2020 •

edited

Loading

alexyao2015 commented Jan 26, 2020 •

edited

Loading

SilveIT commented Jan 26, 2020 •

edited

Loading