Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance fields should probably be StripeQuantumCurrencyAmountField #971

Closed
therefromhere opened this issue Sep 5, 2019 · 0 comments · Fixed by #976
Closed

Balance fields should probably be StripeQuantumCurrencyAmountField #971

therefromhere opened this issue Sep 5, 2019 · 0 comments · Fixed by #976
Labels
good first issue

Comments

@therefromhere
Copy link
Contributor

therefromhere commented Sep 5, 2019 •
edited

These fields are currently IntegerFields, but should probably be StripeQuantumCurrencyAmountField, since they're storing an integer currency value:

  • Customer.balance
  • Invoice.starting_balance
  • Invoice.ending_balance

Should just be a matter of updating the models in question and their existing migrations (since StripeQuantumCurrencyAmountField subclasses IntegerField).

(see #955 for bigger tidyup of currency amount fields)
therefromhere added a commit to prismaticd/dj-stripe that referenced this issue Sep 7, 2019
@therefromhere
Use StripeQuantumCurrencyAmountField for balance
cfd973c 
Instead of a plain IntegerField.  Note that this is non-breaking change since it's still an integer number of cents.

Resolves dj-stripe#971
@therefromhere therefromhere mentioned this issue Sep 7, 2019
Merged
therefromhere added a commit that referenced this issue Sep 7, 2019
@therefromhere
Use StripeQuantumCurrencyAmountField for balance (#976)
3b1172d 
Instead of a plain IntegerField.  Note that this is non-breaking change since it's still an integer number of cents.

Resolves #971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use StripeQuantumCurrencyAmountField for balance prismaticd/dj-stripe
1 participant
@therefromhere