Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed skip dotted labels to use last part #40

Closed
wants to merge 1 commit into from

Conversation

jo-soft
Copy link

@jo-soft jo-soft commented Dec 25, 2014

I had a problem with the original implementation, because it did not find my tests.
Directorty structure:
proj_home/
--manage.py
--apps/
----app1/
--------features/
--------features/environment.py
--------features/userfeeds.feature
--------features/steps/
--------features/steps/app1.py
--------tests/
[ + some additional stuff]

INSTALLED_APPS = [...,
'apps.app1']

now it does and i dont see any complications.

@galuszkak
Copy link
Contributor

This should be rejected in favor of #39 which is far more better implementation with tests.

@jo-soft
Copy link
Author

jo-soft commented Jan 17, 2015

Hey,

yea, I was not aware of the other implementation. This was only a quick
and diry fix. I'm totally with you.

bg,
Johannes

On 16.01.2015 21:28, Kamil Gałuszka wrote:

This should be rejected in favor of #39
#39 which is far
more better implementation with tests.


Reply to this email directly or view it on GitHub
#40 (comment).

@rwillmer
Copy link
Contributor

Thanks for the contribution, but as suggested, I shall close this unmerged in favour of #39

@rwillmer rwillmer closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants