Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example in README to use the class-based views #190

Closed
piotrb5e3 opened this issue Nov 30, 2018 · 2 comments · Fixed by #197
Closed

Update example in README to use the class-based views #190

piotrb5e3 opened this issue Nov 30, 2018 · 2 comments · Fixed by #197

Comments

@piotrb5e3
Copy link

Because of #179 the examples won't work, and could cause more issues like #189 .
@mingchen
Copy link
Collaborator

PR welcome.

This was referenced Jan 15, 2019
Merged
Closed
mingchen added a commit that referenced this issue Jan 15, 2019
@mingchen
Merge pull request #197 from laymonage/patch-login-url-name
2d639f3 
PR #197: Fix #190 Add CAS_LOGIN_URL_NAME to allow custom login url name
@jordiecometrica
Copy link
Contributor

jordiecometrica commented Jun 27, 2019 •
edited

This still isn't fixed:

https://github.com/mingchen/django-cas-ng#view-wrappers-example

I'm trying to figure out how to fix this, but I'm not sure how to actually log in anymore.

The post method of LoginView has a bug, because it returns None unless that logoutRequest parameter is defined:

https://github.com/mingchen/django-cas-ng/blob/master/django_cas_ng/views.py#L52

I'll think about this a bit more and see if I can figure out how to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CAS_LOGIN_URL_NAME to allow custom login url name laymonage/django-cas-ng
3 participants
@mingchen @piotrb5e3 @jordiecometrica