Skip to content

Commit

Permalink
fix: remove fixed width for edit plugin popup (=> autowidth) (#7337)
Browse files Browse the repository at this point in the history
* fix: remove fixed width for edit plugin popup (=> autowidth)

Same behavior as new popup

* fix: revert bundled js

* fix: update changelog

* fix: remove trailing comma
  • Loading branch information
fabien-michel committed Jun 15, 2022
1 parent e7c1f3f commit fcec4c8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ unreleased
* Fix publishing of static placeholders outside of CMS pages
* Allow to override the template rendered after a plugin has been saved.
* Revert change to the toolbar sites menu to use ``http`` protocol.
* Fix edit plugin popup width (remove 850px width contraint).

3.10.0 (2022-03-26)
===================
Expand Down
3 changes: 1 addition & 2 deletions cms/static/cms/js/modules/cms.plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,7 @@ var Plugin = new Class({
modal.open({
url: url,
title: name,
breadcrumbs: breadcrumb,
width: 850
breadcrumbs: breadcrumb
});
},

Expand Down
6 changes: 2 additions & 4 deletions cms/tests/frontend/unit/cms.plugins.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,7 @@ describe('CMS.Plugin', function() {
expect(FakeModal.prototype.open).toHaveBeenCalledWith({
url: '/edit-url',
title: 'Test Plugin',
breadcrumbs: 'breadcrumb',
width: 850
breadcrumbs: 'breadcrumb'
});
});

Expand All @@ -671,8 +670,7 @@ describe('CMS.Plugin', function() {
expect(FakeModal.prototype.open).toHaveBeenCalledWith({
url: '/edit-plugin-url',
title: 'Random Plugin',
breadcrumbs: ['breadcrumb'],
width: 850
breadcrumbs: ['breadcrumb']
});
});
it('adds events to remove the "add plugin" placeholder', function() {
Expand Down

0 comments on commit fcec4c8

Please sign in to comment.