Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n redirect_on_fallback=False and public=False bug #2106

Closed
stefanfoulis opened this issue Jul 30, 2013 · 0 comments · Fixed by #2736
Closed

i18n redirect_on_fallback=False and public=False bug #2106

stefanfoulis opened this issue Jul 30, 2013 · 0 comments · Fixed by #2736

Comments

@stefanfoulis
Copy link
Contributor

the combination of redirect_on_fallback=False with public=False creates undesired results.

LANGUAGE_CODE='de'
CMS_LANGUAGES = {
    1: [
        {
            'code': 'de',
            'name': _('German'),
        },
        {
            'code': 'en',
            'name': _('English'),
            'public': False,
        },
    ],
    'default': {
        'fallbacks': ['en', 'de'],
        'redirect_on_fallback': True,
        'hide_untranslated': False,
        'public': True,
    }
}

With the above settings, if you have a navigate to /en/ (or have language cookie set to 'en' or your default browser language is 'en') as an anonymous/non-staff user, you'll see a page without content.

Expected would be either a redirect to the default language or a 404 (redirect would be more practical).

@digi604 digi604 added this to the 3.0 milestone Feb 10, 2014
digi604 added a commit to digi604/django-cms that referenced this issue Feb 26, 2014
digi604 added a commit that referenced this issue Feb 27, 2014
fix #2106 (redirect on non public root language)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants