Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to display static_placeholder on all sites #2991

Closed
beniwohli opened this issue Mar 31, 2014 · 0 comments · Fixed by #2993
Closed

Ability to display static_placeholder on all sites #2991

beniwohli opened this issue Mar 31, 2014 · 0 comments · Fixed by #2993
Labels
Milestone

Comments

@beniwohli
Copy link
Contributor

In c5b8c6a, a non-nullable FK to Site was introduced for static placeholders, to allow different content on different sites. But it also made a different, valid use case impossible: show the same content on multiple sites.

What about making the site FK nullable, and introduce a new flag to static_placeholder (e.g. "global") to allow static placeholders that are displayed on all sites?

I think the use case of displaying them on some, but not all sites is too much of a fringe case, and it would be difficult to find a UI that is understandable for the user.

@digi604 digi604 added this to the 3.0 milestone Apr 1, 2014
@digi604 digi604 added the blocker label Apr 1, 2014
digi604 added a commit to digi604/django-cms that referenced this issue Apr 1, 2014
digi604 added a commit that referenced this issue Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants