details view should be class based

[philippze]

The details view is a function of more than 100 lines which makes it difficult to extend it. A class based version would make it much easier to create little modifications.

This is my use case:

• Redirect to the domain listed in a page's site field if the page is called with the wrong domain.

Currently this would be done with a middleware where one must determine the requested Page object a second time. It would be easier and more efficient if one could simply override some function in the view code.

[yakky]

Why not using request.current_page in the middleware?
Anyway, while not on top of the todo list, refactoring the view to make it more modular sounds a nice improvement

[philippze]

Fine. So I put refactoring the view on my own todo list and make a pull request some time.

[yakky]

@philippze awesome!

[philippze]

I'm working on this issue today.

I'm proceeding in small steps, try to change no logic, and the tests still work.

However, the code in cms/views.py is looking very different already...