Compatibility with Django compressor? #5454
Comments
|
@czpython separate sekizai block? |
vxsx
added a commit
to vxsx/django-cms
that referenced
this issue
Jun 28, 2016
We use script tag with invalid type to have the template for child classes available but not rendered. Django compressor doesn't know how to handle this type and breaks, so moving that template script out of the sekizai solves the problem. Ref: django-cms#5454
|
Should be fixed by #5463 |
vxsx
added a commit
to vxsx/django-cms
that referenced
this issue
Jun 28, 2016
We use script tag with invalid type to have the template for child classes available but not rendered. Django compressor doesn't know how to handle this type and breaks, so moving that template script out of the sekizai solves the problem. Ref: django-cms#5454
vxsx
added a commit
to vxsx/django-cms
that referenced
this issue
Jun 29, 2016
In commit 4f2ec23, a ``<script type="text/cms-template">`` (for holding client-side content that is not to be rendered until runtime, and which we will use until the HTML element ``<template>`` is fully supported) was placed inside a Sekizai block where it would not interfere with page rendering. Unfortunately, this turned out to be incompatible with Django Compressor django-cms#5454, which raises an error on the (deliberately invalid) ``type="text/cms-template"``. It has been moved out of the Sekizai block to fix this problem. The render-blocking effects of the script are negligible.
vxsx
added a commit
to vxsx/django-cms
that referenced
this issue
Jun 29, 2016
In commit 4f2ec23, a ``<script type="text/cms-template">`` (for holding client-side content that is not to be rendered until runtime, and which we will use until the HTML element ``<template>`` is fully supported) was placed inside a Sekizai block where it would not interfere with page rendering. Unfortunately, this turned out to be incompatible with Django Compressor django-cms#5454, which raises an error on the (deliberately invalid) ``type="text/cms-template"``. It has been moved out of the Sekizai block to fix this problem. The render-blocking effects of the script are negligible.
vxsx
added a commit
to vxsx/django-cms
that referenced
this issue
Jun 30, 2016
In commit 4f2ec23, a ``<script type="text/cms-template">`` (for holding client-side content that is not to be rendered until runtime, and which we will use until the HTML element ``<template>`` is fully supported) was placed inside a Sekizai block where it would not interfere with page rendering. Unfortunately, this turned out to be incompatible with Django Compressor django-cms#5454, which raises an error on the (deliberately invalid) ``type="text/cms-template"``. It has been moved out of the Sekizai block to fix this problem. The render-blocking effects of the script are negligible.
evildmp
pushed a commit
to evildmp/django-cms
that referenced
this issue
Jul 2, 2016
In commit 4f2ec23, a ``<script type="text/cms-template">`` (for holding client-side content that is not to be rendered until runtime, and which we will use until the HTML element ``<template>`` is fully supported) was placed inside a Sekizai block where it would not interfere with page rendering. Unfortunately, this turned out to be incompatible with Django Compressor django-cms#5454, which raises an error on the (deliberately invalid) ``type="text/cms-template"``. It has been moved out of the Sekizai block to fix this problem. The render-blocking effects of the script are negligible.
evildmp
pushed a commit
to evildmp/django-cms
that referenced
this issue
Jul 2, 2016
In commit 4f2ec23, a ``<script type="text/cms-template">`` (for holding client-side content that is not to be rendered until runtime, and which we will use until the HTML element ``<template>`` is fully supported) was placed inside a Sekizai block where it would not interfere with page rendering. Unfortunately, this turned out to be incompatible with Django Compressor django-cms#5454, which raises an error on the (deliberately invalid) ``type="text/cms-template"``. It has been moved out of the Sekizai block to fix this problem. The render-blocking effects of the script are negligible.
|
Fixed by #5463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using django-compressor with sekizai:
After this commit 4f2ec23 a script with type
text/cms-templatewas moved inside an addtoblock "js" block.Django-compressor doesn't know how to handle it and it raises an error.
So when I try to edit a page I get:
Here the file: cms/templates/cms/toolbar/placeholder.html
Is it possible to move the script outside the addtoblock "js" block and the language block?
The text was updated successfully, but these errors were encountered: