Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update diffDOM to the latest version #7461

Closed
wants to merge 3 commits into from

Conversation

petrklus
Copy link

@petrklus petrklus commented Dec 20, 2022

Description

Work in progress on #7460.

Upgrading diffDOM seems to resolve the issue, however, is not compatible with UglifyJS.

Related resources

The issue seems to be related to variable naming in diffDOM:

image

I belive it is due to the variable called node:

https://github.com/fiduswriter/diffDOM/blob/v4.2.8/src/diffDOM/dom/fromVirtual.js#L2

Which UglifyJS does not like. I am seeking help with getting this fix across the finish line.

Checklist

  • I have opened this pull request against develop
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog

@petrklus petrklus changed the title Fix/diffdom Update diffDOM to the latest version Dec 20, 2022
@fsbraun fsbraun changed the title Update diffDOM to the latest version fix: Update diffDOM to the latest version Dec 20, 2022
@@ -49,7 +49,7 @@
},
"dependencies": {
"babel-runtime": "^6.23.0",
"diff-dom": "2.5.1",
"diff-dom": "4.2.8",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it with ^ sign to allow upgrade for minor version in future in package-lock.json file?

@fsbraun fsbraun added kind: bug 3.11 dependencies Pull requests that update a dependency file labels Jan 11, 2023
@fsbraun
Copy link
Sponsor Member

fsbraun commented Jan 18, 2023

@vinitkumar Do you have an idea why the javascript tests fail?

@petrklus
Copy link
Author

@fsbraun @vinitkumar have you been able to get the bottom of the tests failing?

@fsbraun
Copy link
Sponsor Member

fsbraun commented Apr 1, 2023

So far, I have not succeeded. @FinalAngel Do you think you can take a look?

@fsbraun fsbraun deleted the branch django-cms:release/3.11.x May 8, 2023 08:17
@fsbraun fsbraun closed this May 8, 2023
@fsbraun
Copy link
Sponsor Member

fsbraun commented May 15, 2023

@petrklus It seems I have closed this PR. I am not certain why and how. Also, I cannot reopen. Can you reopen this PR?

@petrklus
Copy link
Author

@fsbraun I think it was closed because the branch django-cms:release/3.11.x was deleted - is there any reason why that happened? Could it please be restored so that I can re-create the PR?

@fsbraun
Copy link
Sponsor Member

fsbraun commented May 15, 2023

OMG, I did not do this on purpose! It's restored now. Is there a particular reason you opened the PR against release/3.11.x? The better way would be to open it against develop.

@vinitkumar
Copy link
Member

vinitkumar commented Jun 30, 2023

We will close this PR once #7600 is merged as it does the same thing, but also got the build running.

Also, @petrklus, I added you as a co-author of the commit to properly attribute you for the fix and the initiative. Thanks for helping us figure this one out and of-course of reporting this bug.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Jul 27, 2023

Fixed by #7600. Thank you, @petrklus, for providing this solution!

@fsbraun fsbraun closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 dependencies Pull requests that update a dependency file kind: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants