fixed bug that causes creation of thousands duplicated CacheKey records #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anecdotal support of this: I'd begun seeing a whole bunch of CacheKeys while hacking on an app against develop, but I'd not looked into it. Given this something that previously adversely affected caching, and proposes to fix that, ideally there ought to be a unit or regression test for it, IMHO. |
ojii
added a commit
to ojii/django-cms
that referenced
this pull request
Jan 21, 2012
fixed tests that fail because of django-cms#1145
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found and fixed bug that cause creation of thousands duplicated CacheKey records.
This bug significantly reduces the performance of cache invalidation and use a lot of DB space.
Before was:
