Saner defaults for plugins #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes django-cms#1373. * The default name for plugins is now nicer. * The render method of plugins now by default adds. the instance and placeholder to the context and returns it, eliminating the need to overwrite this method in simple plugins.
|
lgtm |
| @@ -83,7 +83,7 @@ class CMSPluginBase(admin.ModelAdmin): | |||
| form = None | |||
| change_form_template = "admin/cms/page/plugin_change_form.html" | |||
| # Should the plugin be rendered in the admin? | |||
| admin_preview = True | |||
| admin_preview = False | |||
There was a problem hiding this comment.
haha I thought this might be mildly controversial, but that reaction is even better :D
There was a problem hiding this comment.
most plugins end up as unstyled garbage in the admin preview anyway, especially the more involved ones.
|
Very nice. And sane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the instance and placeholder to the context and
returns it, eliminating the need to overwrite this
method in simple plugins.
admin_previewis now False, as it's often useless.