New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using django CMS with custom admin site #3354
Conversation
@@ -3,6 +3,8 @@ | |||
from datetime import datetime | |||
from itertools import chain | |||
import re | |||
from classytags.values import StringValue | |||
from cms.utils.urlutils import admin_reverse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try to organize import statements in some logical order e.g. one recommended in PEP8 (http://legacy.python.org/dev/peps/pep-0008/#id17). It really makes reading and understanding source code much easier. I know that Python can handle randomly ordered import statements but "Beautiful is better than ugly." :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but the CMS code is so far from PEP8 that this PR really doesn't seem like the right place to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not asking to do full PEP8 cleanup in this PR but to at last not make it worse. It costs nothing to put imports in the "right" order but could make django CMS more PEP8 compliant.
We still support python 2.6 :) |
…pace Conflicts: cms/templates/cms/toolbar/plugin.html
@yakky tests pass now |
👍 |
Allow using django CMS with custom admin site
Added a settings
CMS_ADMIN_NAMESPACE
(defaults to'admin'
) to use a non-standardAdminSite
with django CMS.