Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using django CMS with custom admin site #3354

Merged
merged 4 commits into from Aug 10, 2014

Conversation

ojii
Copy link
Contributor

@ojii ojii commented Aug 5, 2014

Added a settings CMS_ADMIN_NAMESPACE (defaults to 'admin') to use a non-standard AdminSite with django CMS.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling 003207e on ojii:custom-admin-namespace into da1fc8d on divio:develop.

@@ -3,6 +3,8 @@
from datetime import datetime
from itertools import chain
import re
from classytags.values import StringValue
from cms.utils.urlutils import admin_reverse

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to organize import statements in some logical order e.g. one recommended in PEP8 (http://legacy.python.org/dev/peps/pep-0008/#id17). It really makes reading and understanding source code much easier. I know that Python can handle randomly ordered import statements but "Beautiful is better than ugly." :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but the CMS code is so far from PEP8 that this PR really doesn't seem like the right place to fix it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not asking to do full PEP8 cleanup in this PR but to at last not make it worse. It costs nothing to put imports in the "right" order but could make django CMS more PEP8 compliant.

@yakky
Copy link
Member

yakky commented Aug 9, 2014

We still support python 2.6 :)
And rebase against latest develop, an unrelated error prevents the testsuite to run on python 3

@coveralls
Copy link

coveralls commented Aug 10, 2014

Coverage Status

Coverage decreased (-0.1%) to 87.167% when pulling cb99898 on ojii:custom-admin-namespace into a794063 on divio:develop.

@ojii
Copy link
Contributor Author

ojii commented Aug 10, 2014

@yakky tests pass now

@yakky
Copy link
Member

yakky commented Aug 10, 2014

👍

yakky added a commit that referenced this pull request Aug 10, 2014
Allow using django CMS with custom admin site
@yakky yakky merged commit 12a275e into django-cms:develop Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants