Bugfix for document.ontouchstart detection #3419
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ $(document).ready(function () { | |||
| this.screenBlock = this.container.find('.cms_screenblock'); | |||
|
|
|||
| // states | |||
| this.click = (document.ontouchstart !== null) ? 'click.cms' : 'touchend.cms'; | |||
| this.click = (document.ontouchstart == null) ? 'click.cms' : 'touchend.cms'; | |||
|
Updated the pull request after doing some testing on our computers. Computer 1 ("win8 normal laptop"): Computer 2 ("win8 laptop with touchscreen"): Since the document.ontouchstart seems to be a bit unreliable it might be best to listen to both. At least it works good for us. |
|
@FinalAngel could you review this quickly? |
|
@digi604 we can implement this, it is yet not a proper solution for the entire mobile editing topic |
FinalAngel
pushed a commit
that referenced
this pull request
Sep 3, 2014
Bugfix for document.ontouchstart detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.