Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS Toolbar unit tests #5110

Merged
merged 18 commits into from
Mar 31, 2016
Merged

CMS Toolbar unit tests #5110

merged 18 commits into from
Mar 31, 2016

Conversation

vxsx
Copy link
Contributor

@vxsx vxsx commented Mar 29, 2016

49.82% → 92.28%

also some fixes to the toolbar itself

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 87.299% when pulling 47c714c on FinalAngel:feature/unit-tests/cms-toolbar into 6868946 on divio:develop.

@FinalAngel
Copy link
Member

LGTM though its pretty long

@vxsx
Copy link
Contributor Author

vxsx commented Mar 30, 2016

test failures are related to #5113

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.8%) to 78.65% when pulling 7979a06 on FinalAngel:feature/unit-tests/cms-toolbar into 6868946 on divio:develop.

@vxsx vxsx mentioned this pull request Mar 30, 2016
Merged
@czpython
Copy link
Contributor

👍 I guess tests fail for another reason now?

@vxsx
Copy link
Contributor Author

vxsx commented Mar 30, 2016

@czpython presumably because of #5113

@coveralls
Copy link

coveralls commented Mar 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-7.8%) to 78.65% when pulling 7979a06 on FinalAngel:feature/unit-tests/cms-toolbar into 6868946 on divio:develop.

@czpython
Copy link
Contributor

Looks like this is ready to land :shipit:

@vxsx vxsx merged commit 391f2ec into django-cms:develop Mar 31, 2016
@vxsx vxsx deleted the feature/unit-tests/cms-toolbar branch March 31, 2016 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vxsx @coveralls @FinalAngel @czpython