Fixed alias plugin preventing operations on the original plugin #5486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
vxsx
force-pushed
the
bugfix/aliased-plugin-double-init
branch
from
1b06f24
to
17214e1
Compare
When alias plugin is initialised it also initialises it's children. If the alias plugin is on the same page as the plugin that is being aliased this leads to the event handlers bound twice. So if you try to toggle context menu or nested plugins in structure mode the operation would be ran twice and would technically fail. This commit stops initialisation of the plugin that already has been initialised. Essentially this is a backport of changes from django-cms#5429 Ref: django-cms#5382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When alias plugin is initialised it also initialises it's children.
If the alias plugin is on the same page as the plugin that is being
aliased this leads to the event handlers bound twice. So if you
try to toggle context menu or nested plugins in structure mode the
operation would be ran twice and would technically fail. This
commit stops initialisation of the plugin that already has been
initialised.
Essentially this is a backport of some of the changes from #5429
Ref: #5382