Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end editing: Add plugin menu does not appear when placeholder is empty #555

Closed

Conversation

aaronrenner
Copy link
Contributor

When trying to add a plugin to an empty placeholder using front-end editing, the "add plugin menubar" is not rendered. This is a regression since the beta-3 release.

It seems there are two lines of code in cmstags.py which prevent render_placeholder from being called. Since the "add plugin menubar" is inserted in render_placeholder, if render_placeholder isn't called the add plugin menubar won't be inserted.

My fix is to remove the two lines which are preventing render_placeholder from being called when the placeholder has no plugins.

@ojii
Copy link
Contributor

ojii commented Oct 8, 2010

this pull request does not solve the issue in an acceptable manner, there will be a fix for this shortly though. Thank you for the effort though.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants