Front-end editing: Add plugin menu does not appear when placeholder is empty #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to add a plugin to an empty placeholder using front-end editing, the "add plugin menubar" is not rendered. This is a regression since the beta-3 release.
It seems there are two lines of code in cmstags.py which prevent render_placeholder from being called. Since the "add plugin menubar" is inserted in render_placeholder, if render_placeholder isn't called the add plugin menubar won't be inserted.
My fix is to remove the two lines which are preventing render_placeholder from being called when the placeholder has no plugins.