Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #588 identifies that when a model extends an existing plugin model rather than extending CMSPlugin directly, the plugin instance is not returned correctly from get_plugin_instance()
This patch includes a simple test case to demonstrate the problem, along with a fix that repairs the problem.
However, I don't think this is the best fix for this issue. The fix came from a comment left by the original developer, however the existing code was obviously intended to take advantage of the fact that the plugin model was already loaded, thus avoiding an extra DB fetch.
I am not familiar enough with this code to find where the plugin model is being attached to the CMSPlugin object - but I suspect that is where the actual fix should be made to permanently resolve this issue.