Fixed reversion in PublisherFix #595
Merged
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is there a css and html changes in a publisher fix pull request? |
|
cms/utils/reversion_hacks.py lines 50-53 need refactorying. Just a plain try-except won't do here. Use the proper lookup using the ORM to see if such a query exists. Generally try...except... should be avoided. In cms/models/pagemodel.py lines 418++, what is that try...except... there for? At least the Exception type should be limited. Same goes for 438++ and 454++, and aggain in cms/models/pluginmodel.py 254++ |
|
Fixed the mentioned issues. All tests pass. But I noticed a new issue with reverting pages with deleted translations , but that is for another bug/ test. |
|
All tests pass, but subclasses of CMSPlugin are not added to Revision, needs more work. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests now pass.
Just a few issues with the patch.
I use the page attribute of CMSPlugin in the selective_post_save_receiver. https://github.com/fivethreeo/django-cms/pull/new/publisherfix#L11R51
Passing the version pk of the revisioned Page along with obj to save_model https://github.com/fivethreeo/django-cms/pull/new/publisherfix#L0R281