prefix_default_language = False redirect behavior fixes #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 5, 2020 16:53
…efix insted of doing isinstance check on pattern only
added 6 commits
May 5, 2020 21:09
…age model cache workaround
|
@victor-yunenko or @Aiky30 can you check if we could merge this into 3.8.x? @zeerooth would you be able to solve the merge conflicts from master and remove the release date in the changelog? |
fsbraun
pushed a commit
to fsbraun/django-cms
that referenced
this pull request
Apr 18, 2023
…cms#6851) * make is_language_prefix_patterns_used check for non-empty language_prefix insted of doing isinstance check on pattern only * if prefix patterns are used get_language_from_request normally, otherwise default * updated CHANGELOG * remove previous details request_language change and replace it with page model cache workaround * fix tests * if prefix patterns are used get_language_from_request normally, otherwise default * add language check workaround to menus as well Co-authored-by: Radosław Stępień <rstepien@cloudferro.com> Co-authored-by: Florian Delizy <florian.delizy@gmail.com>
Merged
4 tasks
fsbraun
added a commit
that referenced
this pull request
Apr 21, 2023
…rd of #6851 to v4) (#7527) * fix: prefix_default_language = False redirect behavior fixes (#6851) * make is_language_prefix_patterns_used check for non-empty language_prefix insted of doing isinstance check on pattern only * if prefix patterns are used get_language_from_request normally, otherwise default * updated CHANGELOG * remove previous details request_language change and replace it with page model cache workaround * fix tests * if prefix patterns are used get_language_from_request normally, otherwise default * add language check workaround to menus as well Co-authored-by: Radosław Stępień <rstepien@cloudferro.com> Co-authored-by: Florian Delizy <florian.delizy@gmail.com> * Fix flake8 issue --------- Co-authored-by: Radek Stępień <rstepien@protonmail.com> Co-authored-by: Radosław Stępień <rstepien@cloudferro.com> Co-authored-by: Florian Delizy <florian.delizy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch aims to mitigate some issues with prefix_default_language set to False, mainly redirect errors:
Related resources
Checklist
develop