Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Release 3.11.0 #7321

Closed
wants to merge 4 commits into from
Closed

build: Release 3.11.0 #7321

wants to merge 4 commits into from

Conversation

creyD
Copy link
Collaborator

@creyD creyD commented May 22, 2022

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@creyD creyD requested a review from marksweb May 22, 2022 23:40
@marksweb marksweb changed the title Release/3.11.0 build: Release 3.11.0 May 22, 2022
Copy link
Sponsor Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static files haven't been given the updated version number. I'm going to assume this is because of the bug I caused to bumping the version number.

@@ -1,6 +1,6 @@
import django

__version__ = '3.10.0'
__version__ = 'test'
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault. I've broken the release script where this is bumped 🤦

Fix for this here; #7322

Copy link
Collaborator Author

@creyD creyD May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I run the script again?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creyD Yeah, my fix is merged so I think we'll close this down, delete the release branch from here, you can do the same from your fork. Then run it again and we should see this version as 3.11.0 and the static files bundle in a folder matching the version.

@marksweb marksweb closed this May 23, 2022
@creyD creyD deleted the release/3.11.x branch May 23, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants