Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Incomplete command to create a virtual env in docs #7735

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Jan 4, 2024

Description

Fixes a missing venv in the command to create a virtual environment

Related resources

Checklist

  • I have opened this pull request against develop
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

github-actions bot commented Jan 4, 2024

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun merged commit 490dffa into release/4.1.x Jan 4, 2024
159 checks passed
fsbraun added a commit that referenced this pull request Jan 5, 2024
* Fix: modal.scss dark-mode compatibilitiy

* Add: Build all assets as part of the frontend test

* fix: Better action feedback

* fix: Update _modal.scss

* fix: Remove publish/draft reference from grouper admin message

* fix ruff

* Add Django 4.2 support to release notes

* Fix transifex-pull-strings

* fix: Update transifex source file (#7629)

* Fix css glitch

* Update translations source fill which was missing strings

* Add migration for page content verbose name

* Fix: Open new plugin window in language of toolbar not of page (#7632)

* Fix: Broken page actions menu if CMS_PERMISSIONS is set

* Build: release 4.1.0rc4 (#7637)

* [4.1.0rc4 release process] Building locales

* [4.1.0rc4 release process] Bumped version to 4.1.0rc4

* [4.1.0rc4 release process] compilemessages

* [4.1.0rc4 release process] compiling new static files

* [4.1.0rc4 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.0.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* fix: en locale in `release/4.1.x` (#7638)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* fix: en locale typo (#7639)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* Fix typo

* Fix: typo: occured -> occurred

* undo mo change

* fix: Remove `can_publish` permission from django CMS 4 core (#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* ci: Merge back 4.1.0.rc5 build into release/4.1.x (#7720)

* [4.1.0rc5 release process] Building locales

* [4.1.0rc5 release process] Bumped version to 4.1.0rc5

* [4.1.0rc5 release process] compilemessages

* [4.1.0rc5 release process] compiling new static files

* [4.1.0rc5 release process] updating latest docs

* Create releases.yml

* Update releases.yml

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update setup.cfg

* Remove py3.8 from setup.cfg

* feat: add v4 docs to main branch (#7722)

* Add docs

* Improve formatting

* Update formatting

* Update changelog for 4.0 from git logs

* Fix typos

* Update docs for frontend testing (#7726)

* fix: Update make-release script to evaluate git diff-index exit codes

* Update make-release to allow for empty messages commit

* chore: Merge `release/build` into `release/4.1.x` (#7729)

* [4.1.0 release process] Bumped version to 4.1.0

* [4.1.0 release process] compilemessages

* [4.1.0 release process] compiling new static files

* [4.1.0 release process] updating latest docs

* Restore 4.0 changelog entries

* fix: Django 5 only allows POST requests to log out (#7728)

* Django 5 only allows POST requests to log out

* Update test

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Apply suggestions from code review

* fix: Incomplete command to create a virtual env in docs (#7735)

* docs: Remove reference to rc5 from 01-install.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
fsbraun added a commit to fsbraun/django-cms that referenced this pull request Feb 7, 2024
* Fix: modal.scss dark-mode compatibilitiy

* Add: Build all assets as part of the frontend test

* fix: Better action feedback

* fix: Update _modal.scss

* fix: Remove publish/draft reference from grouper admin message

* fix ruff

* Add Django 4.2 support to release notes

* Fix transifex-pull-strings

* fix: Update transifex source file (django-cms#7629)

* Fix css glitch

* Update translations source fill which was missing strings

* Add migration for page content verbose name

* Fix: Open new plugin window in language of toolbar not of page (django-cms#7632)

* Fix: Broken page actions menu if CMS_PERMISSIONS is set

* Build: release 4.1.0rc4 (django-cms#7637)

* [4.1.0rc4 release process] Building locales

* [4.1.0rc4 release process] Bumped version to 4.1.0rc4

* [4.1.0rc4 release process] compilemessages

* [4.1.0rc4 release process] compiling new static files

* [4.1.0rc4 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.0.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* fix: en locale in `release/4.1.x` (django-cms#7638)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* fix: en locale typo (django-cms#7639)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* Fix typo

* Fix: typo: occured -> occurred

* undo mo change

* fix: Remove `can_publish` permission from django CMS 4 core (django-cms#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* ci: Merge back 4.1.0.rc5 build into release/4.1.x (django-cms#7720)

* [4.1.0rc5 release process] Building locales

* [4.1.0rc5 release process] Bumped version to 4.1.0rc5

* [4.1.0rc5 release process] compilemessages

* [4.1.0rc5 release process] compiling new static files

* [4.1.0rc5 release process] updating latest docs

* Create releases.yml

* Update releases.yml

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update setup.cfg

* Remove py3.8 from setup.cfg

* feat: add v4 docs to main branch (django-cms#7722)

* Add docs

* Improve formatting

* Update formatting

* Update changelog for 4.0 from git logs

* Fix typos

* Update docs for frontend testing (django-cms#7726)

* fix: Update make-release script to evaluate git diff-index exit codes

* Update make-release to allow for empty messages commit

* chore: Merge `release/build` into `release/4.1.x` (django-cms#7729)

* [4.1.0 release process] Bumped version to 4.1.0

* [4.1.0 release process] compilemessages

* [4.1.0 release process] compiling new static files

* [4.1.0 release process] updating latest docs

* Restore 4.0 changelog entries

* fix: Django 5 only allows POST requests to log out (django-cms#7728)

* Django 5 only allows POST requests to log out

* Update test

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Apply suggestions from code review

* fix: Incomplete command to create a virtual env in docs (django-cms#7735)

* docs: Remove reference to rc5 from 01-install.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
marksweb pushed a commit that referenced this pull request Apr 27, 2024
* Fix: modal.scss dark-mode compatibilitiy

* Add: Build all assets as part of the frontend test

* fix: Better action feedback

* fix: Update _modal.scss

* fix: Remove publish/draft reference from grouper admin message

* fix ruff

* Add Django 4.2 support to release notes

* Fix transifex-pull-strings

* fix: Update transifex source file (#7629)

* Fix css glitch

* Update translations source fill which was missing strings

* Add migration for page content verbose name

* Fix: Open new plugin window in language of toolbar not of page (#7632)

* Fix: Broken page actions menu if CMS_PERMISSIONS is set

* Build: release 4.1.0rc4 (#7637)

* [4.1.0rc4 release process] Building locales

* [4.1.0rc4 release process] Bumped version to 4.1.0rc4

* [4.1.0rc4 release process] compilemessages

* [4.1.0rc4 release process] compiling new static files

* [4.1.0rc4 release process] updating latest docs

* Update CHANGELOG.rst

* Update 4.1.0.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* fix: en locale in `release/4.1.x` (#7638)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* fix: en locale typo (#7639)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: en locale

* Fix typo

* Fix: typo: occured -> occurred

* undo mo change

* fix: Remove `can_publish` permission from django CMS 4 core (#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* ci: Merge back 4.1.0.rc5 build into release/4.1.x (#7720)

* [4.1.0rc5 release process] Building locales

* [4.1.0rc5 release process] Bumped version to 4.1.0rc5

* [4.1.0rc5 release process] compilemessages

* [4.1.0rc5 release process] compiling new static files

* [4.1.0rc5 release process] updating latest docs

* Create releases.yml

* Update releases.yml

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Update setup.cfg

* Remove py3.8 from setup.cfg

* feat: add v4 docs to main branch (#7722)

* Add docs

* Improve formatting

* Update formatting

* Update changelog for 4.0 from git logs

* Fix typos

* Update docs for frontend testing (#7726)

* fix: Update make-release script to evaluate git diff-index exit codes

* Update make-release to allow for empty messages commit

* chore: Merge `release/build` into `release/4.1.x` (#7729)

* [4.1.0 release process] Bumped version to 4.1.0

* [4.1.0 release process] compilemessages

* [4.1.0 release process] compiling new static files

* [4.1.0 release process] updating latest docs

* Restore 4.0 changelog entries

* fix: Django 5 only allows POST requests to log out (#7728)

* Django 5 only allows POST requests to log out

* Update test

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>

* Apply suggestions from code review

* fix: Incomplete command to create a virtual env in docs (#7735)

* docs: Remove reference to rc5 from 01-install.rst

* fix #7826

* Fix merge errors

* Fix readme links

* Undo unwanted change

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
@fsbraun fsbraun deleted the docs/venv-command branch May 12, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant