Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 42 upgrade changes #7834

Merged

Conversation

vipulnarang95
Copy link

Description

Django 4.2 upgrade changes
Dropped Support for Django 3.1 and below

@fsbraun fsbraun added the 4.0.x label Mar 7, 2024
Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml will interpret the version 3.10 as float, i.e. 3.1

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@vipulnarang95 vipulnarang95 changed the title Django 42 upgrade changes [WIP Fixing tests ]Django 42 upgrade changes Mar 8, 2024
@vipulnarang95 vipulnarang95 changed the title [WIP Fixing tests ]Django 42 upgrade changes Django 42 upgrade changes Mar 8, 2024
@joshyu
Copy link

joshyu commented Mar 8, 2024

Hi @fsbraun , please help to review this PR again.

Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one place where it might make sense to replace re_path with path?

cms/admin/settingsadmin.py Outdated Show resolved Hide resolved
@fsbraun fsbraun merged commit 16e260b into django-cms:release/4.0.1.x Mar 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants