Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Patch Toolbar Middleware Response #7856

Merged
merged 2 commits into from Mar 28, 2024

Conversation

jimlind
Copy link

@jimlind jimlind commented Mar 25, 2024

Description

Patch issue where enabling CMS_TOOLBAR_HIDE caused no response from middleware.
Added tests.
All existing tests pass.

Checklist

  • I have opened this pull request against develop
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution! 🎉

As it's your first contribution be sure to check out the contribution docs.

If you're a Slack user and haven't joined us, please do here!

Welcome aboard ⛵️!

@jimlind
Copy link
Author

jimlind commented Mar 25, 2024

Bug Report Created at: #7857

@marksweb
Copy link
Member

A quick look and this looks sensible to me 👍

@fsbraun fsbraun changed the title Patch Toolbar Middleware Response fix: Patch Toolbar Middleware Response Mar 26, 2024
@fsbraun fsbraun merged commit 5fe8855 into django-cms:develop Mar 28, 2024
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants