Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Replace Slack with Discord #7877

Merged
merged 14 commits into from Apr 20, 2024
Merged

docs: Replace Slack with Discord #7877

merged 14 commits into from Apr 20, 2024

Conversation

macolo
Copy link
Sponsor Contributor

@macolo macolo commented Apr 17, 2024 •
edited

Description

  • feature Discord as the main comms channel across all django CMS documentation

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@macolo macolo self-assigned this Apr 17, 2024
fsbraun
fsbraun approved these changes Apr 18, 2024
View reviewed changes
Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marksweb
marksweb reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand discord links but I know they can have time limits. And I note that there's various different links here, so just want to make sure we're happy that they're not likely to expire.

docs/contributing/code.rst Outdated
@@ -17,7 +17,7 @@ Here's what the contribution process looks like in brief:
#. Fork our `GitHub`_ repository, https://github.com/django-cms/django-cms
#. Work locally and push your changes to your repository.
#. When you feel your code is good enough for inclusion, send us a pull request.
#. After that, please join the `Slack Channel`_ of our Pull Request Review work group (#workgroup-pr-review). This group of friendly community members is dedicated to reviewing pull requests. Report your PR and find a “pr review buddy” who is going to review your pull request.
#. After that, please join our Discord server (`#contributors <https://discord.gg/mwRxJSBP>`_). This group of friendly community members is dedicated to reviewing pull requests. Report your PR and find a “pr review buddy” who is going to review your pull request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an unlimited link?

@fsbraun
Copy link
Sponsor Member

fsbraun commented Apr 20, 2024

@macolo @marksweb I have replaced all discord links by https://www.django-cms.org/discord we can manage all redirects there then. For now, this redirects to https://discord.com/channels/800813886689247262/1201999613272535130 which to my understanding is a permanent link. If not, we only need to change the redirect.

@fsbraun fsbraun changed the title Replace Slack with Discord docs: Replace Slack with Discord Apr 20, 2024
@fsbraun fsbraun merged commit a6511da into develop-4 Apr 20, 2024
81 of 82 checks passed
@fsbraun fsbraun deleted the macolo-docs-replace-slack-with-discord branch April 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb left review comments

@fsbraun fsbraun fsbraun approved these changes

Assignees

@macolo macolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@macolo @fsbraun @marksweb