Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install django-filer with SVG support #1305

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

jrief
Copy link
Collaborator

@jrief jrief commented Aug 2, 2022

Description

Since version 2.8.2 of easy-thumbnails one must explicitly install the extra dependencies for SVG. This is done by pip install easy-thumbnails[svg].

This pull request fixes this installation problem.

Related resources

SmileyChris/easy-thumbnails#597

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1305 (f8f5705) into master (7c306dc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   72.21%   72.18%   -0.03%     
==========================================
  Files          72       72              
  Lines        3239     3236       -3     
  Branches      563      559       -4     
==========================================
- Hits         2339     2336       -3     
  Misses        734      734              
  Partials      166      166              
Impacted Files Coverage Δ
filer/admin/views.py 64.17% <0.00%> (-1.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@vinitkumar vinitkumar merged commit df2380c into master Aug 2, 2022
@marksweb marksweb deleted the fix-install-with-svg branch August 2, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants