Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup window name to element id transform #1326

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

stefanw
Copy link
Contributor

@stefanw stefanw commented Dec 20, 2022

Description

Django 4.1 adds a popup index to the admin popup window name that needs to be stripped when getting back to the element id.

This should be backwards compatible to previous element ids unless they use double underscores (__) in them.

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1326 (26e4895) into master (62551a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   72.21%   72.21%           
=======================================
  Files          72       72           
  Lines        3239     3239           
  Branches      468      468           
=======================================
  Hits         2339     2339           
  Misses        734      734           
  Partials      166      166           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Dec 20, 2022

Could that be the root cause of #1317 ?

@stefanw
Copy link
Contributor Author

stefanw commented Dec 20, 2022

Yes, sounds very much like what I experienced.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Dec 20, 2022

Well spotted!! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants