Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ThumbnailOptions instead of a dict #1340

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

jrief
Copy link
Collaborator

@jrief jrief commented May 9, 2023

Description

easy-thumbnails's thumbnailer.get_options() accepts parameter options as type ThumbnailerOptions but it current is passed as dict. This PR fixes that.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1340 (c25dda7) into master (7c22e16) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
+ Coverage   72.39%   72.40%   +0.01%     
==========================================
  Files          72       72              
  Lines        3267     3269       +2     
  Branches      532      532              
==========================================
+ Hits         2365     2367       +2     
  Misses        735      735              
  Partials      167      167              
Impacted Files Coverage Δ
filer/templatetags/filer_admin_tags.py 88.60% <100.00%> (+0.29%) ⬆️

@jrief jrief mentioned this pull request May 9, 2023
4 tasks
Copy link
Sponsor Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrief LGTM.

On a side note, having seen isort removed there. We've started to adopt the ruff linter which combines many linting tools and is really fast.

PR from django-cms v4 here; django-cms/django-cms#7533

@marksweb marksweb merged commit ea1b694 into master May 9, 2023
@marksweb marksweb deleted the use-ThubnailOptions branch May 9, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants