Modernize django filer #1344
Modernize django filer #1344
Conversation
Replace re_path against path Use admin.decorators.action to mark actions Remove dysfunctional jQuery function $.actions()
The Django-Admin loads a JS file named admin/js/actions.js for all list views. It handles the action button on top. Since django-filer handles its actions itself, that button must be mimicked, otherwise a JS error is thrown, complaining that this button can not be found in the DOM.
… into modernize-django
Replace re_path against path Use admin.decorators.action to mark actions Remove dysfunctional jQuery function $.actions() replace History button against Django's own version prevent JS error in Django's actions.js The Django-Admin loads a JS file named admin/js/actions.js for all list views. It handles the action button on top. Since django-filer handles its actions itself, that button must be mimicked, otherwise a JS error is thrown, complaining that this button can not be found in the DOM. flake8 is complaining use proper decorator @action for admin actions drop support for Django<3.2 and Python<3.8 wait with django-4.2 until django-app-helper is up to date fix failing unit tests fix indent complains use proper decorator for templatetag pilfer actions_selection_counter from original Django file drop support for Django<3.2 and Python<3.8
… into modernize-django
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 72.40% 72.02% -0.39%
==========================================
Files 72 72
Lines 3269 3235 -34
Branches 532 537 +5
==========================================
- Hits 2367 2330 -37
- Misses 735 739 +4
+ Partials 167 166 -1
|
| requirements-file: [ | ||
| django-2.2.txt, | ||
| django-3.0.txt, | ||
| django-3.1.txt, | ||
| django-3.2.txt, |
There was a problem hiding this comment.
I'm almost certain django 3.2, 4.0 don't support python 3.11, so some exclusions will still be required.
| @@ -706,115 +682,3 @@ body { | |||
| display: table-cell; | |||
| vertical-align: middle; | |||
| } | |||
|
|
|||
| .filebrowser .navigator-thumbnail-list { | |||
There was a problem hiding this comment.
Are a lot of the code being removed through these files related to this new preview functionality?
As I understand it, the regression issues caused by that features mean certain elements of the UI don't work. But these changes remove so much it'll make it much harder to bring back this feature if it's completely been removed.
Is there not a less destructive way to "hide" it until it's fixed?
There was a problem hiding this comment.
I just reverted to complete pull request, ie. #1255.
It probably is easier for whomever works on it again, to integrate it into the then master branch.
The CSS here is only used for that purpose, so keeping it may introduce a conflict in the future.
setup.py
Outdated
| 'Framework :: Django :: 3.2', | ||
| 'Framework :: Django :: 4.0', | ||
| 'Framework :: Django :: 4.1', | ||
| 'Framework :: Django :: 4.2', |
There was a problem hiding this comment.
why add the 4.2 classifier if the install doesn't allow for 4.2?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This will now be closed due to inactivity, but feel free to reopen it. |
Description
superseeds #1341
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.