-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thumbnail view for folder list admin view (updated) #1255
Conversation
add thumbnail view for folder list admin view cherry-pick changes from django-cms#1076 fix small details (js tests, isort, flake8) maybe a solution to django-cms#723 ?
@corentinbettiol This looks great! I hope that it doesn't create too many conflicts with the pull request adding SVG icons and support in general. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @jrief, sorry for pinging you like this, any news on this PR? Can I do something on my side? |
@corentinbettiol Yeah, you'll need to merge master into this branch and resolve the conflicts. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This will now be closed due to inactivity, but feel free to reopen it. |
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
+ Coverage 71.76% 71.94% +0.17%
==========================================
Files 66 66
Lines 3124 3144 +20
Branches 451 453 +2
==========================================
+ Hits 2242 2262 +20
Misses 729 729
Partials 153 153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@jrief I replaced the bits of code still using the old icons instead of svgs files, it looks great! |
Hi :)
Since it's way more easier to manage images in django-filer with bigger thumbnails instead of the small ones we have in the list, I wanted to add a thumbnail view.
This PR aims to solve #723.
I saw that the PR #1076 already included all the required changes, but for an unknown reason wasn't merged back in 2018. So I cherry-picked the commits and backported them onto the master branch on our fork :)
Here's a demo video (feature is shown at ~ 15 seconds) − And here's a more recent screenshot.