Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnail view for folder list admin view (updated) #1255

Merged
merged 11 commits into from
Jan 20, 2023

Conversation

corentinbettiol
Copy link
Contributor

@corentinbettiol corentinbettiol commented Sep 9, 2021

Hi :)

Since it's way more easier to manage images in django-filer with bigger thumbnails instead of the small ones we have in the list, I wanted to add a thumbnail view.

This PR aims to solve #723.

I saw that the PR #1076 already included all the required changes, but for an unknown reason wasn't merged back in 2018. So I cherry-picked the commits and backported them onto the master branch on our fork :)

Here's a demo video (feature is shown at ~ 15 seconds) − And here's a more recent screenshot.

@jrief
Copy link
Collaborator

jrief commented Sep 10, 2021

@corentinbettiol This looks great! I hope that it doesn't create too many conflicts with the pull request adding SVG icons and support in general.

@stale
Copy link

stale bot commented Jul 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 28, 2022
@corentinbettiol
Copy link
Contributor Author

Hi @jrief, sorry for pinging you like this, any news on this PR? Can I do something on my side?

@stale stale bot removed the stale label Jul 29, 2022
@marksweb
Copy link
Sponsor Member

@corentinbettiol Yeah, you'll need to merge master into this branch and resolve the conflicts.

@stale
Copy link

stale bot commented Oct 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 27, 2022
@stale
Copy link

stale bot commented Nov 24, 2022

This will now be closed due to inactivity, but feel free to reopen it.

@stale stale bot closed this Nov 24, 2022
@marksweb marksweb reopened this Nov 25, 2022
@stale stale bot removed stale labels Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1255 (cf2dcd6) into master (b5213c3) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head cf2dcd6 differs from pull request most recent head 986d71e. Consider uploading reports for the commit 986d71e to get more accurate results

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
+ Coverage   71.76%   71.94%   +0.17%     
==========================================
  Files          66       66              
  Lines        3124     3144      +20     
  Branches      451      453       +2     
==========================================
+ Hits         2242     2262      +20     
  Misses        729      729              
  Partials      153      153              
Impacted Files Coverage Δ
filer/admin/folderadmin.py 71.86% <100.00%> (+0.04%) ⬆️
filer/admin/tools.py 79.48% <100.00%> (+2.67%) ⬆️
filer/templatetags/filer_admin_tags.py 88.31% <100.00%> (+1.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@corentinbettiol
Copy link
Contributor Author

I hope that it doesn't create too many conflicts with the pull request adding SVG icons and support in general.

@jrief I replaced the bits of code still using the old icons instead of svgs files, it looks great!

@jrief jrief merged commit 95cdf42 into django-cms:master Jan 20, 2023
jrief added a commit that referenced this pull request May 10, 2023
@jrief jrief mentioned this pull request May 10, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants