fix: respect upload and directory listing permissions #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r`, `add_file` permissions
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
- Coverage 72.39% 72.35% -0.05%
==========================================
Files 72 72
Lines 3268 3277 +9
Branches 532 534 +2
==========================================
+ Hits 2366 2371 +5
- Misses 735 739 +4
Partials 167 167
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Aiky30
reviewed
Jun 9, 2023
vinitkumar
reviewed
Jun 9, 2023
tests/test_admin.py
Outdated
| 'Filedata': file_obj, | ||
| 'jsessionid': self.client.session.session_key | ||
| } | ||
| response = self.client.post(url, post_data, **extra_headers) # noqa |
Check notice
Code scanning / CodeQL
Unused local variable Note
| 'admin:filer-ajax_upload', | ||
| kwargs={'folder_id': folder.pk} | ||
| ) + '?filename=%s' % self.image_name | ||
| response = self.client.post( # noqa |
Check notice
Code scanning / CodeQL
Unused local variable Note
vinitkumar
approved these changes
Jun 9, 2023
fsbraun
added a commit
that referenced
this pull request
Jun 10, 2023
* fix: respect `can_use_directory_listing`, `change_folder`, `add_folder`, `add_file` permissions * Update tests * fix flake8 error * Close files in tests * Add test for has_... permissions of File and Folder class * Remove unused variables from tests * Remove unnecessary noqa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a security issue: A staff user without any permissions
Thanks to Akshar Tank for reporting this issue.
Fix
This fix enforces the following permissions
can_use_directory_listingchange_folderadd_folderadd_file(also for drag&drop upload)Desired side effects
add_fileto upload filescan_use_directory_listingto browse the filer foldersRelated resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.