Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy folder being broken after django-mptt removal #1393

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

protoroto
Copy link
Contributor

Description

After django-mptt removal, copying folders is broken because insert_at method is not there anymore.
I've added a regression test that should show the error, and then a fix for it that make the test pass.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@protoroto protoroto changed the title Bugfix/copy folder Fix copy folder being broken after django-mptt removal Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1393 (a9856c4) into master (83e209f) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   74.16%   74.78%   +0.61%     
==========================================
  Files          75       75              
  Lines        3445     3442       -3     
  Branches      553      553              
==========================================
+ Hits         2555     2574      +19     
+ Misses        720      698      -22     
  Partials      170      170              
Impacted Files Coverage Δ
filer/admin/folderadmin.py 75.18% <100.00%> (+2.50%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Well spotted and excellent work!

filer/admin/folderadmin.py Outdated Show resolved Hide resolved
@vinitkumar vinitkumar requested a review from marksweb July 20, 2023 09:13
@marksweb marksweb merged commit 3ce96c2 into django-cms:master Jul 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants