Quick: Fix Grid Container get_short_description for Nested Tuples Setting #145

wesleyboar · 2022-01-14T22:46:44Z

To Do

Done

(As necessary) Add test cases. (direction) (done by mark (merged?)
The get_short_description value is inaccurate (see screenshot). (4ba6861, 99dcc07).
Test changes from review (da1f543, 8d8adcb, 4ba6861).

Description

Fix short description for Bootstrap4 Container if user choses container type from nested tuples in DJANGOCMS_BOOTSTRAP4_GRID_CONTAINERS setting.*

* An <optgroup> is available in "Container Type" <select> field when DJANGOCMS_BOOTSTRAP4_GRID_CONTAINERS has deeply-nested tuples. But were user to chose such an option, then get_short_descritpion would return empty string.

Related resources

Checklist

I have opened this pull request against master
I have added or modified the tests when changing logic
My modification is indirect. I changed default value for a constant (settings fallback value), which affects one test.
I have followed the conventional commits guidelines to add meaningful information into the changelog
I have read the contribution guidelines and I have joined #workgroup-pr-review on
Slack to find a “pr review buddy” who is going to review my pull request.
my request for review

Testing

Setup a Django CMS and this branch of djangocms-bootstrap4, e.g.
- install wesleyboar/djangocms-bootstrap4 at wesleyboar:quick/grid-container-support-nested-tuple-choices
- or use wesleyboar/django-cms-quickstart at poc/djangocms-bootstrap4-pull-145 (see diff).¹²
Create a page in the CMS.
Create Container plugin instances on the page for each CONTAINER TYPEs.
✓ Verify the class in the markup of each element added.
⊖ Verify the short description (parenthesized value in Structure mode) is accurate.

choice	class	description
Default → Container	`container`	(Container)
Default → Fluid container	`container-fluid`	(Fluid container)
Custom → Your container	`container-yours`	(Your container)

Screenshots

Added from django.utils.translation import gettext_lazy as _ to your-app/settings.py. ↩
Added sample DJANGOCMS_BOOTSTRAP4_GRID_CONTAINERS to your-app/settings.py. ↩

codecov-commenter · 2022-01-14T22:47:55Z

Codecov Report

❗ No coverage uploaded for pull request base (master@4b5d248). Click here to learn what that means.
The diff coverage is 35.00%.

❗ Current head 58372d7 differs from pull request most recent head b3ed5ed. Consider uploading reports for the commit b3ed5ed to get more accurate results

@@            Coverage Diff            @@
##             master     #145   +/-   ##
=========================================
  Coverage          ?   98.93%           
=========================================
  Files             ?       71           
  Lines             ?     1225           
  Branches          ?      160           
=========================================
  Hits              ?     1212           
  Misses            ?        8           
  Partials          ?        5

Impacted Files	Coverage Δ
djangocms_bootstrap4/helpers.py	`61.76% <23.52%> (ø)`
...gocms_bootstrap4/contrib/bootstrap4_grid/models.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Requires django-cms/djangocms-bootstrap4#145

Also updated fallback choices, default value, and README sample values.

Requires django-cms/djangocms-bootstrap4#145

crydotsnake · 2022-01-18T17:43:23Z

Hello @tacc-wbomar,
Thanks a lot for your contribution!

Looks good, everything worked for me! 😄

…ortcut: commit 997e3c5 Merge: a4e636f bcd8359 Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Tue Jan 18 21:51:04 2022 -0600 Merge branch 'main' into task/FP-1318-section-pattern-as-container-plugin-shortcut commit a4e636f Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Fri Jan 14 18:55:45 2022 -0600 FP-1318: Create Section Pattern via BS4 Container Requires django-cms/djangocms-bootstrap4#145

wesleyboar · 2022-02-21T22:09:30Z

Thank you for the review, @crydotsnake.

How can I accurately describe the status of this PR to dependent parties?

My Effort to Determine Status

I reviewed a contribution doc that mentions "Status", but I don't see on this PR any of the labels it describes.

…gocms-bootstrap4#145)

wesleyboar · 2022-03-11T17:43:26Z

If the PR need be cleaned up anyway before merge, feel free to do it or explain the change for me to do.

(I probably Python and Django'd my way around like a child, so I don't mind direction.)

…sted-tuple-choices

wesleyboar · 2022-06-04T18:16:36Z

I do not know how to write test cases in Python, Django, DjangoCMS. I am disinclined to learn, because I cannot even run the existing test cases. I have followed the instructions.

I get the console error django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty., even though I added SECRET_KEY = 'barrier to entry too high' to /tests/settings.py.

test case run failure console log

source /Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/bin/activate
➜  djangocms-bootstrap4 git:(quick/grid-container-support-nested-tuple-choices) ✗ source /Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/bin/activate
(env) ➜  djangocms-bootstrap4 git:(quick/grid-container-support-nested-tuple-choices) ✗ pip install -r tests/requirements.txt
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'tests/requirements.txt'
WARNING: You are using pip version 22.0.4; however, version 22.1.2 is available.
You should consider upgrading via the '/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/bin/python -m pip install --upgrade pip' command.
(env) ➜  djangocms-bootstrap4 git:(quick/grid-container-support-nested-tuple-choices) ✗ pip install -r tests/requirements/base.txt
Requirement already satisfied: coverage in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 1)) (6.2)
Requirement already satisfied: django-app-helper in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 2)) (3.0.1)
Requirement already satisfied: django-treebeard<4.5 in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 3)) (4.4)
Requirement already satisfied: tox in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 4)) (3.24.5)
Requirement already satisfied: isort in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 6)) (5.10.1)
Requirement already satisfied: flake8 in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 7)) (4.0.1)
Requirement already satisfied: pyflakes>=2.1 in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 8)) (2.4.0)
Requirement already satisfied: wheel in ./env/lib/python3.9/site-packages (from -r tests/requirements/base.txt (line 9)) (0.37.1)
Requirement already satisfied: six in ./env/lib/python3.9/site-packages (from django-app-helper->-r tests/requirements/base.txt (line 2)) (1.16.0)
Requirement already satisfied: docopt in ./env/lib/python3.9/site-packages (from django-app-helper->-r tests/requirements/base.txt (line 2)) (0.6.2)
Requirement already satisfied: dj-database-url in ./env/lib/python3.9/site-packages (from django-app-helper->-r tests/requirements/base.txt (line 2)) (0.5.0)
Requirement already satisfied: Django>=2.2 in ./env/lib/python3.9/site-packages (from django-treebeard<4.5->-r tests/requirements/base.txt (line 3)) (4.0.1)
Requirement already satisfied: packaging>=14 in ./env/lib/python3.9/site-packages (from tox->-r tests/requirements/base.txt (line 4)) (21.3)
Requirement already satisfied: pluggy>=0.12.0 in ./env/lib/python3.9/site-packages (from tox->-r tests/requirements/base.txt (line 4)) (1.0.0)
Requirement already satisfied: toml>=0.9.4 in ./env/lib/python3.9/site-packages (from tox->-r tests/requirements/base.txt (line 4)) (0.10.2)
Requirement already satisfied: filelock>=3.0.0 in ./env/lib/python3.9/site-packages (from tox->-r tests/requirements/base.txt (line 4)) (3.4.2)
Requirement already satisfied: virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0 in ./env/lib/python3.9/site-packages (from tox->-r tests/requirements/base.txt (line 4)) (20.13.0)
Requirement already satisfied: py>=1.4.17 in ./env/lib/python3.9/site-packages (from tox->-r tests/requirements/base.txt (line 4)) (1.11.0)
Requirement already satisfied: pycodestyle<2.9.0,>=2.8.0 in ./env/lib/python3.9/site-packages (from flake8->-r tests/requirements/base.txt (line 7)) (2.8.0)
Requirement already satisfied: mccabe<0.7.0,>=0.6.0 in ./env/lib/python3.9/site-packages (from flake8->-r tests/requirements/base.txt (line 7)) (0.6.1)
Requirement already satisfied: asgiref<4,>=3.4.1 in ./env/lib/python3.9/site-packages (from Django>=2.2->django-treebeard<4.5->-r tests/requirements/base.txt (line 3)) (3.4.1)
Requirement already satisfied: sqlparse>=0.2.2 in ./env/lib/python3.9/site-packages (from Django>=2.2->django-treebeard<4.5->-r tests/requirements/base.txt (line 3)) (0.4.2)
Requirement already satisfied: pyparsing!=3.0.5,>=2.0.2 in ./env/lib/python3.9/site-packages (from packaging>=14->tox->-r tests/requirements/base.txt (line 4)) (3.0.6)
Requirement already satisfied: platformdirs<3,>=2 in ./env/lib/python3.9/site-packages (from virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0->tox->-r tests/requirements/base.txt (line 4)) (2.4.1)
Requirement already satisfied: distlib<1,>=0.3.1 in ./env/lib/python3.9/site-packages (from virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0->tox->-r tests/requirements/base.txt (line 4)) (0.3.4)
WARNING: You are using pip version 22.0.4; however, version 22.1.2 is available.
You should consider upgrading via the '/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/bin/python -m pip install --upgrade pip' command.
(env) ➜  djangocms-bootstrap4 git:(quick/grid-container-support-nested-tuple-choices) ✗ python setup.py test
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing djangocms_bootstrap4.egg-info/PKG-INFO
writing dependency_links to djangocms_bootstrap4.egg-info/dependency_links.txt
writing requirements to djangocms_bootstrap4.egg-info/requires.txt
writing top-level names to djangocms_bootstrap4.egg-info/top_level.txt
reading manifest file 'djangocms_bootstrap4.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
adding license file 'LICENSE'
writing manifest file 'djangocms_bootstrap4.egg-info/SOURCES.txt'
running build_ext
Traceback (most recent call last):
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/setup.py", line 44, in <module>
    setup(
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/setuptools/command/test.py", line 232, in run
    self.run_tests()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/setuptools/command/test.py", line 250, in run_tests
    test = unittest.main(
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/main.py", line 147, in parseArgs
    self.createTests()
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/main.py", line 158, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames,
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 205, in loadTestsFromName
    test = obj()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/tests/settings.py", line 50, in run
    runner.cms('djangocms_bootstrap4')
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/app_helper/runner.py", line 49, in cms
    return runner(argv)
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/app_helper/runner.py", line 109, in runner
    return main(argv)
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/app_helper/main.py", line 374, in main
    return core(args=args, application=application)
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/app_helper/main.py", line 299, in core
    _make_settings(args, application, settings, STATIC_ROOT, MEDIA_ROOT)
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/env/lib/python3.9/site-packages/app_helper/utils.py", line 274, in _make_settings
    django.setup()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/apps/registry.py", line 122, in populate
    app_config.ready()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/contrib/admin/apps.py", line 27, in ready
    self.module.autodiscover()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/contrib/admin/__init__.py", line 24, in autodiscover
    autodiscover_modules('admin', register_to=site)
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/utils/module_loading.py", line 47, in autodiscover_modules
    import_module('%s.%s' % (app_config.name, module_to_search))
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/contrib/auth/admin.py", line 6, in <module>
    from django.contrib.auth.forms import (
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/contrib/auth/forms.py", line 11, in <module>
    from django.contrib.auth.tokens import default_token_generator
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/contrib/auth/tokens.py", line 117, in <module>
    default_token_generator = PasswordResetTokenGenerator()
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/contrib/auth/tokens.py", line 18, in __init__
    self.secret = self.secret or settings.SECRET_KEY
  File "/Users/wbomar/Developer/Code/_demos/djangocms-bootstrap4/.eggs/Django-3.2.11-py3.9.egg/django/conf/__init__.py", line 90, in __getattr__
    raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.

Purpose: django-cms/djangocms-bootstrap4#145

wesleyboar · 2022-06-04T18:28:46Z

To the PR description, I have added sections: "Known Issues", (manual) "Testing" steps, a "Screenshot".

marksweb · 2022-06-04T18:40:55Z

@fsbraun were you going to look over this?

djangocms_bootstrap4/contrib/bootstrap4_grid/constants.py

...tstrap4/contrib/bootstrap4_grid/migrations/0005_change_container_type_choices_and_default.py

djangocms_bootstrap4/contrib/bootstrap4_grid/models.py

fsbraun · 2022-06-06T07:39:20Z

@wesleyboar @marksweb Sorry, I had the review done put left it pending. So I saw it but you couldn't. Should be fixed now!

- do not change default value - thus no need for migration

fsbraun · 2022-06-06T17:17:16Z

I remember having problems with testing, too. Can you try to add SECRET_KEY = "totally secret key nobody should know" to https://github.com/django-cms/djangocms-bootstrap4/blob/master/tests/settings.py ? I am not sure this is sufficient, though.

As a thought starter, here's how I tested first_choice. The right place might by test_helpers.py. For testing get_short_description you might want to look at https://github.com/django-cms/djangocms-bootstrap4/blob/master/tests/bootstrap4_grid/test_models.py

djangocms_bootstrap4/helpers.py

any 2nd tuple was never read cuz `return None` if first element no match

wesleyboar · 2022-06-06T18:09:04Z

I can now run test cases. The problem was that I had not installed Django nor DjangoCMS. I have opened a PR with a change to the README (#152) that may help others.

…choices

marksweb · 2022-06-07T02:29:47Z

I've fixed the tests in master, but can't currently update this PR with the latest changes.

fsbraun

Looks good to me!! Thanks very much!

…sted-tuple-choices

wesleyboar · 2022-08-30T20:42:01Z

Yes, thank you @marksweb. Thanks all of you working on Django.

I did not have time to get back to this. How anyone does open source and holds a job is astounding.

I used the "Sync fork" ▸ "Update branch" button in GitHub which looks to have also merged the upstream master into this branch. (I don't do much forking, so I'm hoping that button ran the correct command.)

fsbraun · 2022-08-30T20:48:16Z

@wesleyboar Do not worry about the failing tests. Once #156 is merged you can sync your fork and we can merge this PR!

wesleyboar · 2022-08-30T20:50:56Z

Thank you. I was. I stop spelunking now.

fsbraun · 2022-09-01T12:44:57Z

@wesleyboar Can you try update branch once more?

…choices

wesleyboar force-pushed the quick/grid-container-support-nested-tuple-choices branch 2 times, most recently from 9907b0a to e691c87 Compare January 15, 2022 00:06

wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Jan 15, 2022

FP-1318: Support Sections via Bootstrap4 Container

32f9565

Requires django-cms/djangocms-bootstrap4#145

wesleyboar force-pushed the quick/grid-container-support-nested-tuple-choices branch 9 times, most recently from 0847a03 to f0c1a9f Compare January 18, 2022 15:57

fix: container get_short_description return blank string for valid value

21db696

Also updated fallback choices, default value, and README sample values.

wesleyboar force-pushed the quick/grid-container-support-nested-tuple-choices branch from f0c1a9f to 21db696 Compare January 18, 2022 16:28

wesleyboar marked this pull request as ready for review January 18, 2022 16:42

wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Jan 18, 2022

FP-1318: Create Section Pattern via BS4 Container

a4e636f

Requires django-cms/djangocms-bootstrap4#145

wesleyboar changed the title ~~Quick: Smart Grid Container get_short_description~~ Quick: Fix Grid Container get_short_description for Nested Tuples Setting Jan 18, 2022

crydotsnake approved these changes Jan 18, 2022

View reviewed changes

wesleyboar mentioned this pull request Jan 18, 2022

FP-1318: Create Section Pattern via Bootstrap Container Plugin TACC/Core-CMS#431

Draft

4 tasks

fsbraun added a commit to django-cms/djangocms-frontend that referenced this pull request Mar 11, 2022

Fix: Set initial values for nested choices correctly (django-cms/djan…

fc8910e

…gocms-bootstrap4#145)

Merge branch 'django-cms:master' into quick/grid-container-support-ne…

dcb4268

…sted-tuple-choices

fsbraun self-requested a review May 27, 2022 18:22

wesleyboar added a commit to wesleyboar/django-cms-quickstart that referenced this pull request Jun 4, 2022

feat(djangocms-bootstrap4): nested tuple setting

07c374e

Purpose: django-cms/djangocms-bootstrap4#145

fsbraun reviewed Jun 6, 2022

View reviewed changes

wesleyboar added 6 commits June 6, 2022 10:29

fix: do not affect users unnecessarily

da1f543

- do not change default value - thus no need for migration

chore: retain original whitepsace

aac1531

fix: get default choice value using flexible logic

8d8adcb

fix: (wip) working and flexible get_short_desc…

4ba6861

fix: import new functions by correct name

119ba95

fix: (wip) fix choice retrieval

ab0d85a

fsbraun reviewed Jun 6, 2022

View reviewed changes

djangocms_bootstrap4/helpers.py Outdated Show resolved Hide resolved

fix: get_short_desc… for elements beyond first

99dcc07

any 2nd tuple was never read cuz `return None` if first element no match

wesleyboar mentioned this pull request Jun 6, 2022

docs(README): fix "Running Tests" instructions #152

Merged

4 tasks

Merge branch 'master' into quick/grid-container-support-nested-tuple-…

921633b

…choices

fsbraun approved these changes Aug 30, 2022

View reviewed changes

Merge branch 'django-cms:master' into quick/grid-container-support-ne…

58372d7

…sted-tuple-choices

fsbraun mentioned this pull request Aug 31, 2022

Support djangocms-static-ace to load ace code editor from static files #156

Merged

4 tasks

Merge branch 'master' into quick/grid-container-support-nested-tuple-…

b3ed5ed

…choices

marksweb merged commit 7543e87 into django-cms:master Sep 1, 2022

wesleyboar deleted the quick/grid-container-support-nested-tuple-choices branch March 30, 2023 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick: Fix Grid Container get_short_description for Nested Tuples Setting #145

Quick: Fix Grid Container get_short_description for Nested Tuples Setting #145

wesleyboar commented Jan 14, 2022 •

edited

codecov-commenter commented Jan 14, 2022 •

edited by codecov bot

crydotsnake commented Jan 18, 2022

wesleyboar commented Feb 21, 2022 •

edited

wesleyboar commented Mar 11, 2022

wesleyboar commented Jun 4, 2022

wesleyboar commented Jun 4, 2022 •

edited

marksweb commented Jun 4, 2022

fsbraun commented Jun 6, 2022

fsbraun commented Jun 6, 2022

wesleyboar commented Jun 6, 2022

marksweb commented Jun 7, 2022

fsbraun left a comment

wesleyboar commented Aug 30, 2022

fsbraun commented Aug 30, 2022

wesleyboar commented Aug 30, 2022

fsbraun commented Sep 1, 2022

Quick: Fix Grid Container get_short_description for Nested Tuples Setting #145

Quick: Fix Grid Container get_short_description for Nested Tuples Setting #145

Conversation

wesleyboar commented Jan 14, 2022 • edited

To Do

Description

Related resources

Checklist

Testing

Screenshots

Footnotes

codecov-commenter commented Jan 14, 2022 • edited by codecov bot

Codecov Report

crydotsnake commented Jan 18, 2022

wesleyboar commented Feb 21, 2022 • edited

wesleyboar commented Mar 11, 2022

wesleyboar commented Jun 4, 2022

wesleyboar commented Jun 4, 2022 • edited

marksweb commented Jun 4, 2022

fsbraun commented Jun 6, 2022

fsbraun commented Jun 6, 2022

wesleyboar commented Jun 6, 2022

marksweb commented Jun 7, 2022

fsbraun left a comment

Choose a reason for hiding this comment

wesleyboar commented Aug 30, 2022

fsbraun commented Aug 30, 2022

wesleyboar commented Aug 30, 2022

fsbraun commented Sep 1, 2022

wesleyboar commented Jan 14, 2022 •

edited

codecov-commenter commented Jan 14, 2022 •

edited by codecov bot

wesleyboar commented Feb 21, 2022 •

edited

wesleyboar commented Jun 4, 2022 •

edited