Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support djangocms-static-ace to load ace code editor from static files #156

Merged
merged 6 commits into from
Sep 1, 2022

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Aug 30, 2022

Description

This PR allows the code editor ace to be served from static files with the help of djangocms-static-ace.

En passant add color scheme detection for the ace editor (dark mode).

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #156 (4380a4f) into master (ee7bcbc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines         1211      1214    +3     
  Branches       155       156    +1     
=========================================
+ Hits          1211      1214    +3     
Impacted Files Coverage Δ
...cms_bootstrap4/contrib/bootstrap4_content/forms.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

README.rst Outdated Show resolved Hide resolved
@marksweb
Copy link
Member

@fsbraun based on the failing test, this may also need an apps.py to define the default auto field.

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Aug 30, 2022

@marksweb The new migrations seem to be happening for cms 3.9. Not sure, apps.py will help. Probably cms 3.9 needed to have a default auto field defined?!?

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Aug 30, 2022

I now skip the migration test for django cms 3.9. This will probably be an issue for other apps, too.

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Aug 31, 2022

@marksweb If you're fine with this, I'd love to merge it and then #145

@marksweb
Copy link
Member

@fsbraun I'll take a look shortly

@marksweb marksweb merged commit d4836f4 into django-cms:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants