Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AbstractPicture.get_size for portrait images + changelog + tests #100

Merged
merged 2 commits into from
May 12, 2022
Merged

Fix AbstractPicture.get_size for portrait images + changelog + tests #100

merged 2 commits into from
May 12, 2022

Commits on Oct 12, 2020

  1. Fix AbstractPicture.get_size for portrait images 

    We input a 1:2 image and set JUST a width limit. The output was a tiny image stretched to our original limit. and was getting out a bizarrely tiny image. This was due to two problems.
 - Only involve the Golden Ratio when you're cropping!
 - Use it in the right direction. When you have a portrait image, you need to inverse the ratio.
    @oliwarner @SteinRobert
    oliwarner authored and SteinRobert committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    e344c24 View commit details
    Browse the repository at this point in the history

  2. - add CHANGELOG.rst entry 

    - add test for portrait image
- add test for missing picture
    @SteinRobert
    SteinRobert committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    b989bee View commit details
    Browse the repository at this point in the history