Fix AbstractPicture.get_size for portrait images + changelog + tests #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We input a 1:2 image and set JUST a width limit. The output was a tiny image stretched to our original limit. and was getting out a bizarrely tiny image. This was due to two problems. - Only involve the Golden Ratio when you're cropping! - Use it in the right direction. When you have a portrait image, you need to inverse the ratio.
- add test for portrait image - add test for missing picture
oliwarner
approved these changes
Jan 24, 2022
marksweb
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests and changelog entry missing in #98