Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: update README #121

Merged
merged 2 commits into from
Jun 21, 2023
Merged

DOCS: update README #121

merged 2 commits into from
Jun 21, 2023

Conversation

corentinbettiol
Copy link
Contributor

Description

Add a "migrate from cmsplugin" management command mention in README.

Related resources

image

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Add a "migrate from cmsplugin" management command mention in README
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #121 (9aaeff4) into master (0923e61) will not change coverage.
The diff coverage is n/a.

❗ Current head 9aaeff4 differs from pull request most recent head e601173. Consider uploading reports for the commit e601173 to get more accurate results

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          244       244           
  Branches        45        27   -18     
=========================================
  Hits           244       244           

Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @corentinbettiol ! Thank you for following up on this. Excellent. I only have some wording suggestions to support what you have written: This is a third-party starting point. Would you be ok with those.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Improve the "migrate from cmsplugin" mention, add a link to the
deprecate_cmsplugin_filer app.
@fsbraun fsbraun merged commit 3a7930c into django-cms:master Jun 21, 2023
6 checks passed
vasekch added a commit to vasekch/djangocms-picture that referenced this pull request Jul 17, 2023
@corentinbettiol corentinbettiol deleted the migrate-snippet branch August 25, 2023 10:20
gruy pushed a commit to gruy/djangocms-picture that referenced this pull request Dec 2, 2023
* DOCS: update README

Add a "migrate from cmsplugin" management command mention in README

* docs: update README

Improve the "migrate from cmsplugin" mention, add a link to the
deprecate_cmsplugin_filer app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants