Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 3.2 to tests #583

Merged
merged 4 commits into from Mar 8, 2022
Merged

Add Django 3.2 to tests #583

merged 4 commits into from Mar 8, 2022

Conversation

DmytroLitvinov
Copy link
Contributor

Closes #582

@DmytroLitvinov
Copy link
Contributor Author

DmytroLitvinov commented Dec 14, 2021

Hi @victor-yunenko,
Could you please review it and approve CI trigger and merge in case if there is no problem with it?

cc @NicolaiRidani

@DmytroLitvinov
Copy link
Contributor Author

Hi @marksweb ,
Could you please rerun CI? Seems like after merging latest changes to master branch it should be ok for now.

@marksweb
Copy link
Member

marksweb commented Mar 7, 2022

@DmytroLitvinov if you merge master into your branch it should see the python tests pass.

@DmytroLitvinov
Copy link
Contributor Author

@marksweb , rebased master. Can you rerun test and merge it if everything is okay?

@marksweb
Copy link
Member

marksweb commented Mar 7, 2022

Absolutely. Thank you @DmytroLitvinov

@vinitkumar
Copy link
Member

@DmytroLitvinov Please rebase master into your branch. We just fixed the CI on the master now, so your tests from this branch should be able to run as well.

@marksweb
Copy link
Member

marksweb commented Mar 8, 2022

@DmytroLitvinov I've left a couple of comments on this, the change log title and dropping EOL python from tests.

Could you take a look please & rebase master as we've just upgraded the gulp pipeline.

@codecov-commenter
Copy link

Codecov Report

Merging #583 (8d6694f) into master (b955396) will not change coverage.
The diff coverage is n/a.

❗ Current head 8d6694f differs from pull request most recent head 7c0fb67. Consider uploading reports for the commit 7c0fb67 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          19       19           
  Lines         829      829           
  Branches      114      114           
=======================================
  Hits          607      607           
  Misses        198      198           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b955396...7c0fb67. Read the comment docs.

@marksweb marksweb merged commit 5dd2974 into django-cms:master Mar 8, 2022
@DmytroLitvinov DmytroLitvinov deleted the add-django-32 branch March 8, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add official support for Django 3.2
4 participants