Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make {{ block.super }} in compress management command a little more robust #198

Merged
merged 1 commit into from
Feb 1, 2012

Conversation

diox
Copy link
Member

@diox diox commented Feb 1, 2012

  • Support multiple {% compress %} calls, with one using {{ block.super }}, inside the same {% block %}
  • Support more complex inheritance chain

…obust

- Support multiple {% compress %} calls, with one using {{ block.super }}, inside the same {% block %}
- Support more complex inheritance chain
jezdez pushed a commit that referenced this pull request Feb 1, 2012
Make {{ block.super }} in compress management command a little more robust
@jezdez jezdez merged commit d63cf0e into django-compressor:develop Feb 1, 2012
@bartek
Copy link
Contributor

bartek commented Feb 3, 2012

There's a problem with this pull request in that if the {% extend %} tag is using a context variable (that may switch dependent on the view using this template), the offline compression fails.

Any thoughts on this?

@diox
Copy link
Member Author

diox commented Feb 3, 2012

Well, anything depending on a context variable can be problematic with offline compression anyway, unless it's something you can add to the COMPRESS_OFFLINE_CONTEXT.

It's probably possible to support dynamic extends, it might even already work in some cases, I haven't tested it. If you open a new bug and submit a testcase I might be able to fix it.

@bartek
Copy link
Contributor

bartek commented Feb 3, 2012

Thank you! I aded an issue here: #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants